-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API refactoring; new error handling flow #270
Comments
@fabriceci, @gmkll, @jsooter, @stevelittlefish, @jlaustill, @forestlake, @sinanbozkus, @richeflits I have reworked the API (located at the dev branch). Not great but very important changes to keep consistency and remove confusing things. Please, take a look the list and update the connectors that you are maintained. @fabriceci, @gmkll, @jlaustill, @forestlake, @sinanbozkus, @richeflits I have made some modifications trying to adjust connectors, but my exprience with non-PHP connectors is not enough to cover all the changes. I don't even have a chance to test the modifications I made, so look through your connectors thoroughly, test updated code and implement the missing features, please. (create PR to the dev branch) @jsooter, @stevelittlefish Both Python Flask connectors are standalone packages, so I had no chance to modify them. Them will become outdated after the v2.7.0 release. Take care to update your connectors, please. |
|
Removed "timestamp" attribute. "created" and "modified" attributes now contain unix timestamps instead of formatted datetime strings. Datetime formatting is performed at the client-side now. |
Released in v2.7.0 |
Changes in the API for v2.7.0
getfile
API method should be RENAMED togetinfo
and return either file or folder stats. Restriction to handle files only should be removed.getfolder
API method should be RENAMED toreadfolder
. No changes in functionality.API methods
readfile
,getimage
anddownload
should USE THE SAME FLOW to read file and write it to the output. The difference will be in headers and restrictions (validation checks) only. Read/Write flow features which should be implemented (preferably):editfile
API method should be REMOVED, instead of it thereadfile
is used at the client-side.download
API method should be simplified and handled with a single request. Implemented within the commit af60b30The error handling. When fire an error you have to add the following HTTP headers to the response:
Also API error format sould correspond to JSON API standard. Imlemented within #210
The text was updated successfully, but these errors were encountered: