Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add paperjs Raster type #3

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Conversation

anotherjesse
Copy link
Contributor

@anotherjesse anotherjesse commented Jun 21, 2019

Sample:

  <Group>
    <Raster
      source="http://assets.paperjs.org/images/marilyn.jpg"
      position={[100, 100]}
    />
    <Circle center={[80, 80]} radius={35} clipMask={true} />
  </Group>

Sample:

      <Group>
        <Raster
          source=http://assets.paperjs.org/images/marilyn.jpg
          position={[100, 100]}
        />
        <Circle center={[80, 80]} radius={35} clipMask={true} />
      </Group>
@anotherjesse
Copy link
Contributor Author

@psychobolt I am new to react/js - so I'm not certain if all the places I added Raster were required.

For instance I saw that Rectangle is not included in export type Paper = {... Is that by design or an accident?

@psychobolt
Copy link
Owner

It is not by design that I didn't implement Rectangle type. As of now flow types are not fully implemented.

@psychobolt psychobolt merged commit 223f458 into psychobolt:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants