Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to a bug related to static component #2124

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

PanBartosz
Copy link
Contributor

bytes(compName) does not work in Python 3 and because of that static component does not work too.
replacing it by str(compName) fixed the problem

`bytes(compName)` does not work in Python 3 and because of that static component does not work too.
replacing it by `str(compName)` fixed the problem
@codecov-io
Copy link

codecov-io commented Dec 2, 2018

Codecov Report

Merging #2124 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
+ Coverage   42.93%   42.95%   +0.01%     
==========================================
  Files         215      215              
  Lines       37756    37756              
  Branches     6500     6500              
==========================================
+ Hits        16212    16218       +6     
+ Misses      19989    19985       -4     
+ Partials     1555     1553       -2
Impacted Files Coverage Δ
psychopy/experiment/components/static/__init__.py 68.6% <0%> (ø) ⬆️
psychopy/visual/window.py 67.96% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbefeea...835a947. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 47.071% when pulling 835a947 on PanBartosz:patch-1 into fbefeea on psychopy:master.

@peircej peircej merged commit 0d918fd into psychopy:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants