Catch error when User Creation Email fails at UserCreationService

[MackenzieMolloy]

In the current 1.x release of Pterodactyl, when a Pterodactyl instance doesn't have emails configured or email details are invalid, administrative users are given a '500 Error' screen when creating a user rather than being shown the successfully created user's details page.

In this PR, I've simply caught the error and logged it. Opting not to display the error to the user, the user is then redirected to the successfully created user screen. There are many instances where emails aren't configured and the instance administrator is aware, so it makes sense not to hinder the user creation sequence.

I did consider returning an email sent successful state as part of the UserCreationService#handle, to then forward onto the user along with the new user object, however I was unsure if it would cause any major conflicts with forks or some project-specific software design choices I am unaware of.

I was thinking something similar to this if I were to return the error with the user object: https://hastebin.com/share/hamifisihe.php

Any feedback welcome. :)

[danny6167]

I've never ran into this before.
Are you using sync as your QUEUE_DRIVER or something ?

[MackenzieMolloy]

I've never ran into this before. Are you using sync as your QUEUE_DRIVER or something ?

Yes, I am.

[danny6167]

Honestly, using sync for the queue driver is such an edge case as it's really only designed for local development and not something we recommend for production at all. I can't see us wanting to merge this.

If you want an easier way of making your config work, try setting the mail driver to array

[danny6167]

Thank you for your submission, but I don't see us merging this.