Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GID from config for container #106

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

NoahvdAa
Copy link
Contributor

@NoahvdAa NoahvdAa commented Oct 2, 2021

The wings config file has an option for specifying the GID, but it doesn't seem to be used in the container. This PR aims to fix that by passing the configured gid to the container config. This seems to do the job, as shown in the highly advanced tests below /s

Before:
image

After:
image

@parkervcp
Copy link
Member

The user is to identify outside the container what user is used to own the files. Matching in the container is probably a good idea.

We should probably update the yolks and images to actually use 997 to make the container user before this gets implemented though.

@DaneEveritt
Copy link
Member

No, because 997 is not the guaranteed ID of the user, the host can change it. We can pass the group through, just need to confirm it didn't break any existing images. I don't agree with making a user in the container.

@DaneEveritt DaneEveritt merged commit 13a9ee9 into pterodactyl:develop Jan 20, 2022
@NoahvdAa NoahvdAa deleted the fix/gid-for-container branch January 20, 2022 06:39
ThaDaVos pushed a commit to ThaDaVos/wings that referenced this pull request Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants