-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shovelknight: missing symbols (sdl2), ptlresolver #37
Comments
Ok, commit 9d60c8e should have fixed the SDL2 missing symbol. Maybe it runs now? |
That fixed the sdl symbols and pltresolver, however the game still fails to boot (flashes a game window then segfaults).
and using your gl4es fixes the missing gl warnings, but still crashes.
|
I'll try to add some of the missing wrapper for the RPi OpenGL. But I guess it's not linked to the crash. Can you do a gdb backtrace of it? (launch box86 using |
(and I have added more wrpper for OpenGL 4.4 and 4.5) |
Sorry for taking so long, had a bit of trouble with gdb, wasn't sure how to add the BOX86_LD_LIBRARY_PATH. In the end i just add each need lib to default path.
|
Ah, so thre is an issue with SDL_RWops... damn. Can you do another run with |
Ah no wait, it's ok, I think I know what is happening... |
Ok, I pushed a hack/workaround. I hope it works. |
Just tried it, and sadly i get the same seg fault error. Would you like me to bt full again or bt full with log=debug? |
maybe the BOX86_LOG=DEBUG then. |
So, I have completly changed the way SDL2 RWops are handled. Hopefully, I didn't broke anything and everything is working fine. This need some testing of course. If you can try on ShovelKnight. |
And I fixed plenty of issues. It should works now. |
Awesome! Will try now :D
…On Tue, 30 Jul 2019 at 19:22, ptitSeb ***@***.***> wrote:
And I fixed plenty of issues. It should works now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#37?email_source=notifications&email_token=ALG5GBPBXIYIRBJDAKCLZFLQCCBG3A5CNFSM4IHPYOWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3E3KWI#issuecomment-516535641>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALG5GBNULSE6XEMAR4O2J6TQCCBG3ANCNFSM4IHPYOWA>
.
|
just tried, and sadly it still seg faults.
trying to boot with gl4es
|
And heres the bt
|
Ah, so there is some progress. I can see gl4es make it crash :( but even with VC4 driver, it crash. But it's a memset now, so probably some other function that gives a wrong pointer. Ideally, running with |
would you like me to post the log here or should i pastebin it? the output was over 100k lines haha |
Just paste the last few lines here (something like 20), it should be enough. |
sure, heres the last few lines.
|
Mmmm, that doesn't seems enough. I guess there will be quite a few lines with the all the "Curstom Binding Update" printf. It seems the function is before that... |
No wait, I have seen something. A couple of SDL2 function needs better wrapping (the return SDL_JoystickGUID like SDL_JoystickGetGUIDFromString) |
Ah okay. Heres a 1/8th post from the log, started from the bottom (ignoring what i already pasted here). |
So I have a fixed a few stuff with SDL2 Joystick, maybe it's better now. |
I am very happy to report that the game now boots!!! Amazing work once again! However there is no sound currently. This if s from the cmd output (after printing out everything its loaded in)
Just to add, the game seg faults when using gl4es. |
Nice ! About the sound, maybe it's just a few OpCode missing. I've just added the 0F 6B XX one... About random lock, that will be more tricky to find, as I assume it is something with thread and/or TLS, but it's not a crash... For the crash with gl4es, that"s a shame, if you can give me a gdb backtrace of the crash, I may understand what's missing or wrong, but that's not the priority of this issue. |
You work so fast! That fixed the sound. What logs would you need from me to hep find the cause for the crash? Ill add the bt for gl4es to this comment in a few mins. Just testing to see if the lock up happens after a set amount of time. Also the game is fullspeed, thought you'd like to know ;) |
Okay ive been playing the game for 40 minutes so far and no lockup. Previously the lockup would happen after 1-2 mins. I guess we can consider this issue fully solved 👍 Though as for gl4es, would you like me to open a separate issue or carry on here? And as for gdb, how do i pass arguments that need to go before the binary. So far i've been using gdb --args box86 ShovelKnight, how would i add LIBGL_ES=2 LIBGL_GL=21 LIBGL_DIBGL_FBOFORCETEX=1 LD_LIBRARY_PATH=~/monolibs |
For gdb, add them in front gdb, like for any other program:
should works fine. For gl4es, yes, if you can open a ticket in gl4es repo, that would be easier. And I guess this one can be closed if ShovelKnight works fine (how is the speed? Oh, wait, you said it was fullspeed! Nice :D ) |
Yup that worked, thought i already tried that command but looks like i didn't, my bad! And the game runs at fullspeed at full 1080p, great stuff once again. Closing now 👍 |
sorry about the long command at the start, its leftover from the other games i tested :)
The text was updated successfully, but these errors were encountered: