Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading metro to v0.45.2 #217

Open
aleclarson opened this issue Dec 25, 2018 · 2 comments
Open

Upgrading metro to v0.45.2 #217

aleclarson opened this issue Dec 25, 2018 · 2 comments
Labels

Comments

@aleclarson
Copy link
Collaborator

aleclarson commented Dec 25, 2018

Hey, I've been working on upgrading the metro dependency from v0.24.3 to v0.45.2 (which is a version I've recently added symlink support to).

I think you'll find my commits useful, but many of them depend on improvements I've made to metro and jest-haste-map which are not yet merged.

Here's the list of the commits you can cherry-pick without upgrading metro or anything:

  • baec902 fix: add jest/hasteImpl.js
  • 06e66bb Add support for out-of-tree platform plugins (#20825)
  • c7bbfe6 feat: inject "macos" platform automatically
  • 74d1d81 Pass the maxWorkers config param correctly to Metro
  • 759be09 fix: "react" peer dependency
  • c352cc1 fix: "Duplicate declaration" transform error
  • 641309d fix: "optional rest parameters" eslint error

Side note: None of the above are related to upgrading Metro. I just fixed these as I was upgrading.

Commits 1 thru 3 are my favorite, because they let you omit the platforms and providesModuleNodeModules properties from your metro.config.js module.

But commit 4 is really nice too, since it fixes some config options that were being overwritten by defaults.

@aleclarson
Copy link
Collaborator Author

If you want, I can send a PR with all of these. :)

@ptmt
Copy link
Owner

ptmt commented Dec 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants