Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node extracted twice #1

Open
jpoikela opened this issue Jan 26, 2018 · 6 comments
Open

Node extracted twice #1

jpoikela opened this issue Jan 26, 2018 · 6 comments

Comments

@jpoikela
Copy link
Contributor

I think you have a bug here:

rt-rrt/rt.py

Line 299 in 8f40302

qr.insert(0, x_closest[NODE])

x_closest is already the node of the result

@ptsneves
Copy link
Owner

I cannot understand this part. I looked at the paper and this seems to be correct. Can you elaborate, or tell me how can I verify this duplication?

@jpoikela
Copy link
Contributor Author

what I mean is that you already have:
x_closest = result[NODE]
then you take
x_closest[NODE]
in the suspicious line which does not seem correct (but may still be)..

@ptsneves
Copy link
Owner

Will take a loot at it. Also I think this algorithm is quite crappy for real life world discovery. I will try to contact the authors of the paper to see what they think.

@jpoikela
Copy link
Contributor Author

jpoikela commented Feb 23, 2018 via email

@ptsneves
Copy link
Owner

Sure. I think that a review by the authors, plus better presentation can be beneficial for both of us.

Regarding the ellipse sampling, basically once you find a route to the goal you take the path distance as a parameter for the ellipse for convergent sampling.
I was honestly quite disappointed with this step as I was thinking of the ellipse sampling as some mathematical heuristic that could help us get to the goal faster, but it seems it is some form of ad-hoc optimization heuristic.

In the mean time I modified my code to provide the shortest path given the known nodes, basically short-circuiting the graph-tree when there is no obstacle. I am curious if I am not doing some La-palice here :D

@jpoikela
Copy link
Contributor Author

I agree that the authors would be best guides.
shortest routes, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants