-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: remove naming convention ci check #220
ci: remove naming convention ci check #220
Conversation
This change switches pbgrub to commit messages without prefix. Closes pubgrub-rs#218
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t have anything against. It was a good guard rail at some point but I’m also ok with not having it.
How is the changelog going to work? |
We can start using PR labels. Note that we're not really losing anything, the changelog structure is different than the commit labels |
The previous change logs were maintained manually. As no one volunteered to set up tooling that used the conventional commits. Considering approximately everything has changed since the last public release the next logs is going to be hand authored, even if we had tooling set up. So 🤷 |
Ah if they're not being used for changelog generation than I'm pretty against conventional commit enforcement (but it's not really my project) |
Indeed, this was introduced by Alex, mainly for commit consistency. Considering the (deliberate) few number of releases, it made more sense to me to craft change logs and release notes manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can insist on this again in the future when someone wants to use tooling to solve release notes being too big/hard. Until then no need.
This change switches pubgrub to commit messages without prefix.
Tagging everyone to sign off before merging.
Closes #218