-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added update functionality #153
Conversation
Hi @lgandecki thank you for the great work. I will review it at the weekend. |
await docs.update(updateObj); | ||
} | ||
return docs; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could possibly extract this and remove to a common function, it's very similar (the only two differences are the "action" (.update vs .remove) and the fact that update takes an argument)
Up to you - some people like to apply a rule of three :)
Any news on this? Looks promising |
I messed up the merge. Some tests are not working. Can you reopen the PR? |
Very few changes to the actual code, since all the hard work is getting done in the modifyjs package.
I have a simple test case here just to check the integration, all the heavy lifting tests are done in modifyjs package src/modify.test.js
At this point all of the mongodb examples are working, with an exception of:
There might be more edgecases that don't work and didn't surface while going through the mongodb examples, but we/I can try to tackle them one by one. :)
Please let me know what you think.