Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include crededentials in graphql client #3976

Merged

Conversation

marcoklein
Copy link
Contributor

This PR contains:

  • A NEW FEATURE

Describe the problem you have without this PR

This is a feature for #3439

This Pull Request adds the option to pass the credential parameter to the underlying GraphQL client. Without it the application will not send any cookies to other domains since the credentials option is same-origin per default. See the spec documentation at https://fetch.spec.whatwg.org/#concept-request-credentials-mode

Todos

  • Tests
  • Documentation
  • Typings
  • Changelog

How should I update the changelog?

@pubkey
Copy link
Owner

pubkey commented Sep 14, 2022

Code looks good but there is nothing about the setCredentials() in the docs changes.
I will add teh changelog afterwards, you do not have to care about that.

@marcoklein
Copy link
Contributor Author

marcoklein commented Sep 14, 2022

What do you mean exactly? I updated the docs-src/replication-graphql.md to include some documentation but when I run npm run docs:build I get lots of changes in the docs folder so I thought you run that separately.

EDIT: saw that I had a typo in there. Updated the docs now.

@pubkey pubkey merged commit 5936d9b into pubkey:master Sep 14, 2022
pubkey added a commit that referenced this pull request Sep 14, 2022
@pubkey
Copy link
Owner

pubkey commented Sep 14, 2022

Great, merged.
Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants