GraphQL replication: should stop syncing if we receive less docs than pull.batchSize #4110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Describe the problem you have without this PR
If we send the initialSync with a batchSize of
5
, the server last response will contain less than the batchSize (let say2
) and instead of finishing the initial replication, rxdb will always request a last time because it ends only if there are no document in the response. Actually the batchSize interface tells us, that the replication will stops if the response contains less documents than the batchSize, which is currently not trueIt will also be preferrable to resolve this case, cause we also prevent relying on the server to stop the sync process.
Currently we have, at work, a endpoint that need to be fix, it includes in the response the document that fits the checkpoint.updatedAt, so the initialSync() never stop.