Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing extensions error field to errorToPlainJson #6029

Merged

Conversation

AleksandrMatuka
Copy link
Contributor

This PR contains:

A BUGFIX

Describe the problem you have without this PR

missing extensions field to the error object (v14 regression).

Related discussion: #5952

@AleksandrMatuka AleksandrMatuka marked this pull request as draft May 22, 2024 00:32
@AleksandrMatuka AleksandrMatuka marked this pull request as ready for review May 22, 2024 07:18
@AleksandrMatuka AleksandrMatuka changed the title fix: Add missing extensions error field to errorToPlainJson ( minor ) fix: Add missing extensions error field to errorToPlainJson May 22, 2024
@pubkey
Copy link
Owner

pubkey commented May 22, 2024

Hi @AleksandrMatuka
The change looks good. Please add a unit test.

@AleksandrMatuka
Copy link
Contributor Author

AleksandrMatuka commented May 22, 2024

Hi @AleksandrMatuka The change looks good. Please add a unit test.

@pubkey updated with unit test, let me know if we need a more extensive one here

@pubkey pubkey merged commit fdf9e19 into pubkey:master May 23, 2024
20 checks passed
pubkey added a commit that referenced this pull request May 23, 2024
@pubkey
Copy link
Owner

pubkey commented May 23, 2024

Thank you, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants