Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Pusher a soft dependency #12

Closed
stas opened this issue Jul 11, 2012 · 8 comments
Closed

Make Pusher a soft dependency #12

stas opened this issue Jul 11, 2012 · 8 comments
Assignees
Milestone

Comments

@stas
Copy link
Contributor

stas commented Jul 11, 2012

Since pusher is optional, it would be nice to make it a soft dependency and just mention it in the documentation if people really want to use it.

Thanks.

@pokonski
Copy link
Member

Good idea. I think about going a little further and making it more configurable - so people can configure p_a to use any sort of push gems (in callbacks for Activity model)

@ghost ghost assigned pokonski Jul 11, 2012
@stas
Copy link
Contributor Author

stas commented Jul 11, 2012

👍 Even better!

@pokonski
Copy link
Member

Pusher dependency is now removed on 0.4.0-wip branch => 03913bc. I will document how to add your own callbacks to the Activity class on that branch.

@pokonski
Copy link
Member

Closing this as resolved, will be available in 0.4.0.

@stas
Copy link
Contributor Author

stas commented Jul 19, 2012

Thanks and sorry for delay.

May I ask whats the status of 0.4.0 branch? I'm working on something and was wondering if the gem is worth being used for some pre-release testing/stressing.

@pokonski
Copy link
Member

0.4.0 passes tests and is stable for what it offers,but it lacks documentation for changes I made.
Especially p_a doesn't inject itself into ActiveRecord anymore, you just include it in the model like this:

class Post < ActiveRecord::Base
  include PublicActivity::Model   # this is new
  tracked
end

This is a preparation for supporting other adapters, like mongoid.

The basic functionality should be good to go, but I cannot guarantee this will remain in the current state.

@myKingEdem
Copy link

This is related to #45; Its clear that pusher is not need, but no documentation on how to add callbacks.

@pokonski
Copy link
Member

It is in the demo app. PublicActivity::Activity is just an Active Record
model so AR callbacks are needed.
25 gru 2012 00:47, "Raymond Cudjoe" notifications@github.com napisał(a):

This is related ti #45#45;
Its clear that pusher is not need, but no documentation on how to add
callbacks.


Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-11667224.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants