-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Pusher a soft dependency #12
Comments
Good idea. I think about going a little further and making it more configurable - so people can configure p_a to use any sort of push gems (in callbacks for Activity model) |
👍 Even better! |
Pusher dependency is now removed on 0.4.0-wip branch => 03913bc. I will document how to add your own callbacks to the Activity class on that branch. |
Closing this as resolved, will be available in 0.4.0. |
Thanks and sorry for delay. May I ask whats the status of 0.4.0 branch? I'm working on something and was wondering if the gem is worth being used for some pre-release testing/stressing. |
0.4.0 passes tests and is stable for what it offers,but it lacks documentation for changes I made. class Post < ActiveRecord::Base
include PublicActivity::Model # this is new
tracked
end This is a preparation for supporting other adapters, like mongoid. The basic functionality should be good to go, but I cannot guarantee this will remain in the current state. |
This is related to #45; Its clear that pusher is not need, but no documentation on how to add callbacks. |
It is in the demo app. PublicActivity::Activity is just an Active Record
|
Since pusher is optional, it would be nice to make it a soft dependency and just mention it in the documentation if people really want to use it.
Thanks.
The text was updated successfully, but these errors were encountered: