Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cw721_base::msg::QueryMsg::Minter to cw721::msg::Cw721ExecuteMsgMinter? #138

Closed
taitruong opened this issue Aug 20, 2023 · 1 comment

Comments

@taitruong
Copy link
Collaborator

Afaik cw721 package is supposed to be used by consumer contracts - whilst cw721-base is for a custom cw721 contract.
If consumer can query all kinds of data using package - except for minter, wherecw721_base is required. Shouldn't we move it there?

I remember goal of package having it close erc721 spec. But package also allows it querying for contract_info which doesn't exist in erc721.

If above msg should be moved, as a consequence cw-ownable should be part of package.

Also Extension is an optional part of ERC721. Maybe this should also be moved to package?

@taitruong
Copy link
Collaborator Author

fixed in v19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant