Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hall of Fame" for most stuck issues #257

Open
jywarren opened this issue Aug 21, 2019 · 12 comments
Open

"Hall of Fame" for most stuck issues #257

jywarren opened this issue Aug 21, 2019 · 12 comments
Labels

Comments

@jywarren
Copy link
Member

I was looking at some old and very stuck issues which I'd love to fix, but are really obscure. And sometimes I get an insight months or years later and fix one. I was thinking it'd be fun to post a "hall of fame" of extremely stuck issues which we've almost given up on. Sometimes people are in a mood to take one on. Sometimes a fresh look is worth it.

Here are some of mine! 😅

I'm sure there are more!

What do folks think of this? It could just be a unique tag like hall-of-fame 🙈

@pydevsg
Copy link
Member

pydevsg commented Aug 23, 2019

Hello @jywarren , I have gone through this issue, it really is hard for a beginner to start off working on this issue 😢 , can you tell me from where should I start working on this issue.
I would then like to work on this 😄

@Rishabh570
Copy link
Collaborator

@jywarren Actually hall-of-fame issue label is a considerably good idea, the other thing that we can do is showing that list to the page (where the issues will be filtered following the similar approach as of stale issues') but I don't think that would be the most suitable thing to do...what do you think?

@pydevsg As it is not quite sure what should be done as of now, let's wait for some input...suggestions are welcome though :)

@pydevsg
Copy link
Member

pydevsg commented Aug 23, 2019

I will wait for it :)

@jywarren
Copy link
Member Author

jywarren commented Aug 23, 2019 via email

@pydevsg
Copy link
Member

pydevsg commented Aug 23, 2019

Thankyou @jywarren , I will try to understand the codebase.
For time being i will be happy if you provide few first timers issues to me :)

@Rishabh570
Copy link
Collaborator

Hi @pydevsg, you can go ahead with this issue...do the required changes as shown in the issue description, run grunt build, commit & push and create a PR for it.
Ping me if you need any help 😄

@jywarren Hmm, putting it at the bottom sounds good, but how "old" the issue should be to be included in that list?... Maybe more than 2-3 months?

@jywarren
Copy link
Member Author

Here's another for the hall of fame! publiclab/plots2#3007

Ah, we can drive it off of a label like hall-of-fame to keep this pretty simple 😄 How about that?

@Rishabh570
Copy link
Collaborator

Adding hall-of-fame label would be more customizable because if we decide to add a list, that would be filtering issues based on the time the issue was last updated...in some cases, we might not want to include all of that issues to the hall-of-fame.

Also, if we end up adding a label for the hall of fame issues, we can show that list to the bottom of the page just like fto and fto-candidate list. This would give us a place better explain what they are all about...what do you think?

@jywarren
Copy link
Member Author

jywarren commented Aug 27, 2019 via email

@jywarren
Copy link
Member Author

OK, we've made the label! https://github.com/publiclab/plots2/labels/hall-of-fame

@jywarren
Copy link
Member Author

Adding mockup idea from @Rishabh570 -- thanks!

image

@jywarren
Copy link
Member Author

And i believe we should try to get these for all such labeled issues across the org, just like we do here for the first-timers-only issues:

toolbox.getIssuesForOrg(org, { qs: { labels: ftoLabel } })
.then(displayIssuesAndFtoAuthors('.first-timers-only'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants