Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install GPU.js v2.3.1 #1374

Merged
merged 9 commits into from Dec 21, 2019
Merged

Install GPU.js v2.3.1 #1374

merged 9 commits into from Dec 21, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Dec 19, 2019

Fixes #1348 (<=== Replace 0000 with the Issue Number
Fixes #1292

NOTE: This is a continuation of #1356

  • Installed GPU.js v2.3.1 which fixes Blur module on small screen sizes
  • @robertleeplummerjr the browserify error for gpu.js

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@harshkhandeparkar
Copy link
Member Author

Other Changes:

  • Text Overlay and Blob Analysis module tests failed due to the absence of WebGL in node. They also don't use puppeteer so they will not be tested. An issue regarding this will be opened soon.

@keshav234156
Copy link
Member

@keshav234156
Copy link
Member

test benchmarks are running now .Great!!!

@harshkhandeparkar
Copy link
Member Author

Have a look at #1375

@harshkhandeparkar
Copy link
Member Author

Also:

  1. More modules eg: FisheyeGL and WebGLDistort which use puppeteer are now benchmarked.

@harshkhandeparkar
Copy link
Member Author

Travis still fails though. I will find a solution for that.

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Dec 21, 2019

@jywarren @keshav234156 @publiclab/is-reviewers This is working - at least locally. With the help of @robertleeplummerjr, I was able to successfully browserify the tests and run them. v2.3.1 of gpu.js and the later versions can be used now. The Blur module bug on smaller screens has been fixed now.

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #1374 into main will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1374   +/-   ##
=======================================
  Coverage   66.12%   66.12%           
=======================================
  Files         125      125           
  Lines        2571     2571           
  Branches      404      404           
=======================================
  Hits         1700     1700           
  Misses        871      871
Impacted Files Coverage Δ
src/modules/_nomodule/gpuUtils.js 83.87% <100%> (ø) ⬆️

@harshkhandeparkar
Copy link
Member Author

The installation errors should also be fixed now. Awesome!

@harshkhandeparkar harshkhandeparkar added dependencies Pull requests that update a dependency file important labels Dec 21, 2019
@robertleeplummerjr
Copy link

Woot!

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Dec 21, 2019 via email

@jywarren
Copy link
Member

This is awesome!!!!

@jywarren jywarren merged commit c370a8b into publiclab:main Dec 21, 2019
@keshav234156
Copy link
Member

Awesome!!

@keshav234156
Copy link
Member

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Dec 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation error Bugs in Blur module and modules which are using blur module
4 participants