Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tape from 4.13.0 to 5.1.1 #1786

Closed
wants to merge 1 commit into from

Conversation

dependabot-preview[bot]
Copy link

@dependabot-preview dependabot-preview bot commented Jan 5, 2021

Bumps tape from 4.13.0 to 5.1.1.

Commits
  • 3b924b0 v5.1.1
  • b505c4c [readme] Document unexpected t.end() behavior
  • 7aff9e4 [readme] Added tabe into reporter list
  • 8e60dcb [Robustness] cache and call-bind more prototype methods
  • b19da31 [Refactor] use call-bind/callBound instead of function-bind directly
  • 04da90b [eslint] ensure no trailing commas
  • 0743333 [Tests] make stripFullStack output an array of lines, for better failure me...
  • d505cdf [Fix] preserve stack traces for returned Promises (async/await)
  • 82c3904 [meta] do not publish github action workflow files
  • 4210e44 [Tests] add npm run test:example to test non-failing examples.
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot requested a review from a team as a code owner January 5, 2021 05:50
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jan 5, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jan 5, 2021

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 2 times, most recently from aa6b96b to b982b56 Compare January 19, 2021 13:41
@daemon1024
Copy link
Member

@dependabot rebase

@dependabot-preview
Copy link
Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@daemon1024
Copy link
Member

@dependabot recreate

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 2 times, most recently from b982b56 to cbd6638 Compare January 19, 2021 14:02
@daemon1024
Copy link
Member

Checks failing 😢

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 8 times, most recently from 0079d66 to 6924fd5 Compare January 21, 2021 12:21
@jywarren
Copy link
Member

Well, it is a major version bump...

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 2 times, most recently from 8f708ea to 39f8b7c Compare January 25, 2021 19:01
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 5 times, most recently from 49a6f8e to 7f4c7df Compare February 8, 2021 23:08
@daemon1024 daemon1024 mentioned this pull request Feb 10, 2021
7 tasks
@jywarren
Copy link
Member

OK, so base tests report 2 errors; here they are:

    ✖ .end() already called: noise-reduction module works correctly with initial option undefined
    ----------------------------------------------------------------------------------------------
      operator: fail
      at: <anonymous> (/home/runner/work/image-sequencer/image-sequencer/test/core/templates/options-test.js:40:11)
      stack: |-
  Error: .end() already called: noise-reduction module works correctly with initial option undefined
    ✖ .end() already called: white-balance module works correctly with initial option undefined
    --------------------------------------------------------------------------------------------
      operator: fail
      at: <anonymous> (/home/runner/work/image-sequencer/image-sequencer/test/core/templates/options-test.js:40:11)
      stack: |-
  Error: .end() already called: white-balance module works correctly with initial option undefined

Then browserified core tests returns a few instances of this error:

    ✖ convolve outputs correct array1
    ----------------------------------
      operator: deepEqual
      expected: |-
        [ [ 12, 19, 26 ], [ 13, 20, 27 ], [ 13, 20, 27 ], [ 13, 19, 25 ] ]
      actual: |-
        [ { 0: 12, 1: 19, 2: 26 }, { 0: 13, 1: 20, 2: 27 }, { 0: 13, 1: 20, 2: 27 }, { 0: 13, 1: 19, 2: 25 } ]
      stack: |-
  Error: convolve outputs correct array1
  at Test.assert [as _assert] (http://localhost:43329/bundle.js:124433:54)
  at Test.bound [as _assert] (http://localhost:43329/bundle.js:124254:32)
  at Test.tapeDeepEqual (http://localhost:43329/bundle.js:124674:10)
  at Test.bound [as deepEqual] (http://localhost:43329/bundle.js:124254:32)
  at Test.<anonymous> (http://localhost:43329/bundle.js:136979:5)
  at Test.bound [as _cb] (http://localhost:43329/bundle.js:124254:32)
  at Test.run (http://localhost:43329/bundle.js:124271:31)
  at Test.bound [as run] (http://localhost:43329/bundle.js:124254:32)
  at next (http://localhost:43329/bundle.js:124029:19)
  at onNextTick (http://localhost:43329/bundle.js:125113:12)


    ✖ convolve outputs correct array2
    ----------------------------------
      operator: deepEqual
      expected: |-
        [ [ 14, 19, 24 ], [ 12, 13, 14 ], [ 15, 12, 9 ], [ 16, 13, 10 ] ]
      actual: |-
        [ { 0: 14, 1: 19, 2: 24 }, { 0: 12, 1: 13, 2: 14 }, { 0: 15, 1: 12, 2: 9 }, { 0: 16, 1: 13, 2: 10 } ]
      stack: |-
  Error: convolve outputs correct array2

I also see a lot of this in there:

    [CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 6e 6f 74 20 @+0]
    WebAssembly acceleration errored; falling back to JavaScript in PixelManipulation

And this is happening:

  Load ndvi-colormap meta module

    TypeError: fs.readFileSync is not a function
        at http://localhost:43329/bundle.js:135687:30
        at Image.img.onload (http://localhost:43329/bundle.js:25622:5)
    WebAssembly acceleration errored; falling back to JavaScript in PixelManipulation
    TypeError: fs.readFileSync is not a function
        at http://localhost:43329/bundle.js:135687:30
        at Image.img.onload (http://localhost:43329/bundle.js:25622:5)
    WebAssembly acceleration errored; falling back to JavaScript in PixelManipulation

@jywarren
Copy link
Member

These seem workable errors, actually. I wonder if something on the array output changed causing this (what is generating these outputs?):

      expected: |-
        [ [ 12, 19, 26 ], [ 13, 20, 27 ], [ 13, 20, 27 ], [ 13, 19, 25 ] ]
      actual: |-
        [ { 0: 12, 1: 19, 2: 26 }, { 0: 13, 1: 20, 2: 27 }, { 0: 13, 1: 20, 2: 27 }, { 0: 13, 1: 19, 2: 25 } ]

That's within gpuUtils:

const out = convolve([array], kernel);
t.equal(out.length, 1, 'convolve returns a single output array');
t.equal(out[0][0].length, 3, 'ouput array width is correct');
t.equal(out[0].length, 4, 'ouput array height is correct');
t.deepEqual(out[0], expectedOut, 'convolve outputs correct array');

That's this file, modified in #1374 by @harshkhandeparkar --

https://github.com/publiclab/image-sequencer/blob/3caa033c8febf5055c28f616b534933c00fcbe65/src/modules/_nomodule/gpuUtils.js

but that was over a year ago; this GPU.js update was from 21 days ago: #1790 so maybe it's responsible? I don't see anything likely though in the release notes...

@jywarren
Copy link
Member

and that latest GPU.js passed all tests, so prob not!

@jywarren
Copy link
Member

That previous run did have these messages and passed anyways so they may not be related;

    [CompileError: WebAssembly.instantiate(): expected magic word 00 61 73 6d, found 6e 6f 74 20 @+0]
    WebAssembly acceleration errored; falling back to JavaScript in PixelManipulation

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch 3 times, most recently from 7fa7385 to 535ba0f Compare February 16, 2021 05:48
Bumps [tape](https://github.com/substack/tape) from 4.13.0 to 5.1.1.
- [Release notes](https://github.com/substack/tape/releases)
- [Commits](tape-testing/tape@v4.13.0...v5.1.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/tape-5.1.1 branch from 535ba0f to 3824f3a Compare February 19, 2021 15:22
@dependabot-preview
Copy link
Author

Superseded by #1820.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/tape-5.1.1 branch February 22, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants