sort sql injection vulnerability, add gem brakeman #1214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right_aws is no longer maintained, was throwing an error
render :text will be deprecated and poses a security risk
* Add new system tests and fix minor asset loading * modify test * Add chromedriver to travis * Add sudo * Add dependencies to dockerfile * Properly installing chrome and chromedriver
* WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * WIP action cable setup * basic action cable setup complete * minor change * minor changes * few changes * initial working functionality complete * Refactoring code * Adding Foreman gem * Scheduling Puma and Passenger servers * few minor fix * added a few tests * Refactoring connection module * Using strong params in requests * added documentation * added more docs * added tests * Using puma as dependency and correct image controller * added a few tests * a few changes * remove unnecessary render * few test fixes
* few bug fixes * separate editing channels for different maps * test fixes * rubocop fixes
|
Thanks for opening this pull request! |
|
Code Climate has analyzed commit 8c1d634 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #1214 +/- ##
===========================================
- Coverage 73.28% 42.05% -31.23%
===========================================
Files 40 40
Lines 1400 1574 +174
===========================================
- Hits 1026 662 -364
- Misses 374 912 +538
|
jywarren
requested changes
Jan 21, 2020
app/controllers/users_controller.rb
Outdated
| @@ -13,7 +13,7 @@ def index | |||
| @users = User.joins(:maps) | |||
| .select('users.*, count(users.id) as maps_count') | |||
| .group('maps.user_id') | |||
| .order(sort_column + ' ' + sort_direction) | |||
| .order(sort_column => sort_direction) | |||
There was a problem hiding this comment.
Ah, could we do sort_column: sort_direction here?
Then, let's rebase and this looks great! Thank you @StlMaris123 !!!
Gemfile
Outdated
| @@ -74,6 +74,7 @@ group :development, :test do | |||
| gem 'faker', '~> 2.6.0' | |||
| gem 'pry-rails', '~> 0.3.9' | |||
| gem 'action-cable-testing' | |||
| gem 'brakeman' | |||
There was a problem hiding this comment.
Looks great @StlMaris123
But I think brakeman is used only to detect vulnerabilities right?
So it should be better to add this to the development group if it isn't being used in production.
|
Rebase taking too long to complete, closing this pr and opening another one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1189 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!