-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codeclimate.yml #521
Add codeclimate.yml #521
Conversation
e417ba3
to
62b8544
Compare
Couple things here, i noticed CodeClimate had the default branch set to I also turned on PR status updates but the webhooks isn't turning on -- i press "Install" but it still shows the "Install" button, unlike the PR status updates. |
Hmm, i can't seem to get it to turn on. Should I merge this anyways? |
Ah the webhooks button has a bug. It shows "install" after webhooks gets installed successfully. So I think that's fine! |
Ok then!!! |
Great work here!!! |
@jywarren Most of the issues on codeclimate are rubocop style offences(2000/2300) |
hey @kaustubh-nair, if you can open FTOs for those codeclimate issues that'd be great. Thank you! |
@gauravano Most of them are refactoring issues due to too many lines of code. I think that will be too much for a first timer? Or will it not? |
Hmm, it depends on how good codeclimate describes the solution. Sometimes, their solution is good and sometimes not. But, I have also dropped a word in #533 so maybe we can use those for generating FTOs and yeah, we have to do the effort. |
Fixes #514
Make sure you have Pull request status updates and webhooks turned on in the codeclimate settings page for the repo
Thanks!