Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeclimate.yml #521

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Add codeclimate.yml #521

merged 1 commit into from
Apr 14, 2019

Conversation

kaustubh-nair
Copy link
Member

Fixes #514
Make sure you have Pull request status updates and webhooks turned on in the codeclimate settings page for the repo
Thanks!

@kaustubh-nair
Copy link
Member Author

@jywarren I didn't integrate test coverage with travis since coveralls already does this.(supposed to do this. Until #491 is fixed)

@jywarren
Copy link
Member

Couple things here, i noticed CodeClimate had the default branch set to master so I changed it to main.

I also turned on PR status updates but the webhooks isn't turning on -- i press "Install" but it still shows the "Install" button, unlike the PR status updates.

@jywarren
Copy link
Member

Hmm, i can't seem to get it to turn on. Should I merge this anyways?

@kaustubh-nair
Copy link
Member Author

Ah the webhooks button has a bug. It shows "install" after webhooks gets installed successfully. So I think that's fine!

@jywarren
Copy link
Member

Ok then!!!

@jywarren jywarren merged commit 58fd5af into publiclab:main Apr 14, 2019
@jywarren
Copy link
Member

Great work here!!!

@kaustubh-nair
Copy link
Member Author

@jywarren Most of the issues on codeclimate are rubocop style offences(2000/2300)
I can break these up in small parts and create a lot of FTO issues. Should I proceed with this?

@grvsachdeva
Copy link
Member

hey @kaustubh-nair, if you can open FTOs for those codeclimate issues that'd be great. Thank you!

@kaustubh-nair
Copy link
Member Author

@gauravano Most of them are refactoring issues due to too many lines of code. I think that will be too much for a first timer? Or will it not?

@grvsachdeva
Copy link
Member

Hmm, it depends on how good codeclimate describes the solution. Sometimes, their solution is good and sometimes not. But, I have also dropped a word in #533 so maybe we can use those for generating FTOs and yeah, we have to do the effort.

chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up codeclimate
3 participants