Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #662

Closed
wants to merge 1 commit into from
Closed

Update README.md #662

wants to merge 1 commit into from

Conversation

Hasan-aga
Copy link

@Hasan-aga Hasan-aga commented Jun 3, 2019

I changed the 1st line to be as given in your discription, this is my first pull request, let me know if you have any feedback

Fixes #687 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

I changed the 1st line to be as given in your discription
@welcome
Copy link

welcome bot commented Jun 3, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@codeclimate
Copy link

codeclimate bot commented Jun 3, 2019

Code Climate has analyzed commit b91d214 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #662 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #662   +/-   ##
=======================================
  Coverage   41.36%   41.36%           
=======================================
  Files          34       34           
  Lines        1308     1308           
=======================================
  Hits          541      541           
  Misses        767      767

@sashadev-sky
Copy link
Member

hi @hasan-ali! So sorry for the delay in the review. So another user already opened a PR for this and its ready for merge. But here is a different update that can be made here:'

Lets add a badge for first-timers-only friendly, like we have in the plots2 repository. You can undo the other update and instead add this line:

[![first-timers-only-friendly](http://img.shields.io/badge/first--timers--only-friendly-blue.svg?style=flat-square)](https://code.publiclab.org#r=all)

which will show up as this:
first-timers-only-friendly

I will promptly open an issue for this and assign you to it, but you can get started! In the future, in order for us to catch your PR, you must tag the issue # where it says fixes #0000

@sashadev-sky
Copy link
Member

sashadev-sky commented Jun 13, 2019

@hasan-ali Ok its opened #687

I linked it for you under fixes #0000. See how it's linked on that page now?

@sashadev-sky
Copy link
Member

closed this user has opened a new PR for this #694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add first-timers-only-friendly badge to README
2 participants