-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the dotted line from OAuth button options #981
Conversation
Thanks for opening this pull request! |
Code Climate has analyzed commit f58bfac and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #981 +/- ##
==========================================
+ Coverage 73.26% 73.62% +0.36%
==========================================
Files 40 40
Lines 1384 1384
==========================================
+ Hits 1014 1019 +5
+ Misses 370 365 -5
|
Well done. Looks good to me. Merging this up @jywarren! |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
* Remove unwanted container_name * Reference web container for current compose project * Change docker for docker-compose reference * Change initializer to factory syntax (#944) * change to factory syntax * fix typo * Update app/assets/javascripts/mapknitter/Annotations.js Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com> * Update app/assets/javascripts/mapknitter/Annotations.js Co-Authored-By: Gaurav Sachdeva <sachdeva.gaurav1997@gmail.com> * try different syntax * Put env var in right place * Run instead of exec to be able to pass env vars. * Pointer fix for Image options (#935) * Latest pull from upstream * Pointer changes * Deeleted extra files * Delete passenger.3000.pid.lock Deleted file * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Last update to app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update _index.html.erb * Update _index.html.erb * Update CODE_OF_CONDUCT.md (#992) Update code of conduct to reflect changes on https://publiclab.org/conduct Aug 28th, 2019 * Removed the dotted line from OAuth button options (#981) * Grid-view-follow-up (#964) * Bump bootsnap from 1.4.4 to 1.4.5 (#977) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.4...v1.4.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Setting ForeGO instead of Foreman (#995) * Setting up ForeGO in favor of Foreman(deprecated) * Bundle updating gems * Bump faker from 2.1.2 to 2.2.1 (#984) Bumps [faker](https://github.com/faker-ruby/faker) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/faker-ruby/faker/releases) - [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md) - [Commits](faker-ruby/faker@v2.1.2...v2.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * change run to exec * run instead of exec
* Remove unwanted container_name * Reference web container for current compose project * Change docker for docker-compose reference * Change initializer to factory syntax (publiclab#944) * change to factory syntax * fix typo * Update app/assets/javascripts/mapknitter/Annotations.js Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com> * Update app/assets/javascripts/mapknitter/Annotations.js Co-Authored-By: Gaurav Sachdeva <sachdeva.gaurav1997@gmail.com> * try different syntax * Put env var in right place * Run instead of exec to be able to pass env vars. * Pointer fix for Image options (publiclab#935) * Latest pull from upstream * Pointer changes * Deeleted extra files * Delete passenger.3000.pid.lock Deleted file * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Last update to app/views/images/_index.html.erb Co-Authored-By: Divya Baid <32747809+divyabaid16@users.noreply.github.com> * Update _index.html.erb * Update _index.html.erb * Update CODE_OF_CONDUCT.md (publiclab#992) Update code of conduct to reflect changes on https://publiclab.org/conduct Aug 28th, 2019 * Removed the dotted line from OAuth button options (publiclab#981) * Grid-view-follow-up (publiclab#964) * Bump bootsnap from 1.4.4 to 1.4.5 (publiclab#977) Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/Shopify/bootsnap/releases) - [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md) - [Commits](Shopify/bootsnap@v1.4.4...v1.4.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Setting ForeGO instead of Foreman (publiclab#995) * Setting up ForeGO in favor of Foreman(deprecated) * Bundle updating gems * Bump faker from 2.1.2 to 2.2.1 (publiclab#984) Bumps [faker](https://github.com/faker-ruby/faker) from 2.1.2 to 2.2.1. - [Release notes](https://github.com/faker-ruby/faker/releases) - [Changelog](https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md) - [Commits](faker-ruby/faker@v2.1.2...v2.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * change run to exec * run instead of exec
Fixes #970 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/mapknitter-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
![after](https://user-images.githubusercontent.com/23080198/64060870-e6450680-cba0-11e9-9fc1-285cb5fe341a.jpg)