-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mock PR to initiate CI service #5
Conversation
For some reason the token's empty https://travis-ci.com/publiclab/matcher-cli/jobs/209094455#L488 |
@jywarren This will now work for any PR to |
OK, this is cool - can you write in the docs OR in the comments that it posts, explaining what we're seeing in these screenshots? Like, how will someone coming here know what they're looking at, or if it's good or bad? Thanks Pranshu!!! |
And also, although I see https://travis-ci.com/publiclab/matcher-cli/jobs/209157049, it's not clear to me if the |
@rexagod great work, thank you! I agree with Jeff, it may help others in the future quite a lot. May I help you in any way? |
Oh whoa, we were in the PR, just commenting on the commits within it! Sorry, I'd just never seen that approach to commenting before. Thanks! |
So, i don't quite understand here, does this PR represent new code? Why is it a "Mock PR"? Sorry @rexagod i just am having some trouble understanding your workflow... can you explain what's going on here? Thanks! |
I think perhaps it's a good idea to think of a general workflow of:
That makes it a lot easier for others to follow what you're doing, you know? Thanks for all your hard work, @rexagod, I think it's really cool! I'm just trying to provide some input on your workflow to help it be more readable to others! |
No description provided.