Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Display of User Email Page on Large Screens #11267

Closed
5 tasks
TildaDares opened this issue Jul 12, 2022 · 7 comments · Fixed by #11278
Closed
5 tasks

Refine Display of User Email Page on Large Screens #11267

TildaDares opened this issue Jul 12, 2022 · 7 comments · Fixed by #11278
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@TildaDares
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -1,5 +1,4 @@
-<div class="col-lg-3">&nbsp;</div>
-<div class="col-lg-9">
+<div class="col-lg-9 mx-auto my-0">

    <h3>User lookup by email:</h3>

@@ -10,15 +9,15 @@
           <i class="fa fa-search fa fa-white"></i>
        <% end %>
        </button>
-       <label>
+       <label class="d-block">
          <input type="checkbox" id="myCheck" name="include_banned" />
-         Include banned accounts after 2015 (careful: can result in server slowness for all users)
+         Include banned accounts after 2015 (<em>careful: can result in server slowness for all users</em>)
        </label>
    <% end %>

    <br>
    <% if @address %>
-   <h3>Searched for <%= @address %>(<%= @users.size %>)</h3>
+   <h4>Searched for <%= @address %>(<%= @users.size %>)</h4>
    <% if @users.size > 0 %>
    <ul>
       <% @users.each do |user| %>

Before && After

Screenshot 2022-07-12 at 17 54 07

Screenshot 2022-07-12 at 17 54 29

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below, and reach out in our chatroom!

@TildaDares TildaDares added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Jul 12, 2022
@TildaDares
Copy link
Member Author

Reserved for @Kshitiz-Mhto for 24 hours!

@AbhayK200417
Copy link
Contributor

@TildaDares Can I work on this?

@TildaDares
Copy link
Member Author

Hi @AbhayK200417, contributors are only allowed to work on one FTO issue. Thanks!

@TildaDares
Copy link
Member Author

Reassigning!

@TildaDares
Copy link
Member Author

Reserved for @jindalj for 24 hours!

@Kshitiz-Mhto
Copy link
Contributor

Hi @TildaDares honestly, i was sick and was inactive for two days. i m fit and fine now, if you could find good first issue for me too, that would be so nice of you.

@TildaDares
Copy link
Member Author

Hi @Kshitiz-Mhto, of course I'll add your name back on the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants