Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nokogumbo gem warning #11528

Closed
cesswairimu opened this issue Oct 21, 2022 · 10 comments · Fixed by #11536
Closed

Fix nokogumbo gem warning #11528

cesswairimu opened this issue Oct 21, 2022 · 10 comments · Fixed by #11536

Comments

@cesswairimu
Copy link
Collaborator

Logs are showing this warning

Fix `.rvm/gems/ruby-2.7.3/gems/nokogumbo-2.0.4/lib/nokogumbo/html5.rb:13: warning: already initialized constant Nokogiri::HTML5::HTML_NAMESPACE`

Could be fixed by these steps:

  • run bundle update nokogumbo - this will update nokogumbo to v 1.2.5 and maybe also update nokogiri in Gemfile.lock
  • Remove older versions of nokogumbo and nokogiri from Gemfile.lock(optional)
  • Check if app running okay
  • Commit and make PR to see if tests are passing

Refer to: sparklemotion/nokogiri#2205

@7malikk
Copy link
Contributor

7malikk commented Oct 21, 2022

@cesswairimu can i give this a go?

@cesswairimu
Copy link
Collaborator Author

Go ahead @7malikk, lets leave #11529 for another contributor. thanks

@7malikk
Copy link
Contributor

7malikk commented Oct 21, 2022

Go ahead @7malikk, let's leave #11529 for another contributor. thanks

@cesswairimu I just completed #11529 I can leave this one for another contributor

@cesswairimu
Copy link
Collaborator Author

cool 👍 thanks

@Ibom99
Copy link
Contributor

Ibom99 commented Oct 22, 2022

@cesswairimu Can I work on this fix?

@victory-lydia
Copy link
Contributor

@cesswairimu Please can I work on this issue

@cesswairimu
Copy link
Collaborator Author

@Ibom99 , you can go ahead, @victory-lydia I am still working on the warnings, I will ping you if I create a similar one. thanks

@Ibom99
Copy link
Contributor

Ibom99 commented Oct 22, 2022

Thank you @cesswairimu i’ll get on it!

@victory-lydia
Copy link
Contributor

Thanks @cesswairimu will be waiting

@Jennifer-tech
Copy link

Hi @cesswairimu please can I get an issue to work on too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants