page number buttons are displayed twice

[keshavsethi]

In https://publiclab.org/tag/question:general
here page numbers are displaying twice as shown:

[neelesh17]

Can I claim this issue?

[keshavsethi]

Here Asked and Answered buttons are not working as well thatswhy answered questions are not rendered on clicking thus that div remain empty and it shows two pagination as shown below

@cesswairimu @SidharthBansal @VladimirMikulic @nstjean can you please review this issue
Thanks!!

[VladimirMikulic]

This is in fact an issue. @neelesh17 you can take this if that's fine by @keshavsethi.

[cesswairimu]

Great catch. Thanks

[keshavsethi]

@VladimirMikulic actually I was working on this but if @neelesh17 has started this then it is fine :)

[tyler-wel]

So I take it progress hasn't been made? If no one is currently looking at it, I can try and take a look 😄

[avats-dev]

So I take it progress hasn't been made? If no one is currently looking at it, I can try and take a look smile

That would be awesome, thanks for stepping up on this. 🚀

[tyler-wel]

Note on the issue

https://publiclab.org/questions/
Questions are displayed correctly with one pagination bar

https://publiclab.org/questions/tag/camera
Displays two pagination bars

Seems to be a problem with the tags routing

Edit: After inspecting the html, seems to be both question and answered pagination rendering at the same time

[tyler-wel]

Both _questions.html and _answered.html are rendering their @pagy pagination.

_tab_content has the below users/answered partial rendering even though the tab is not active. Also, it seems as if @answered_questions exists at this point, but there is no mention of @answered_questions inside of _answered.html

<div class="tab-content">
  <div class="tab-pane active" id="asked-tab">
    <%= render partial: "questions/new_question" %>
  </div>

  <div class="tab-pane" id="answered-tab">
    <% if @answered_questions %>
      <%= render partial: "users/answered" %>
    <% end %>
  </div>
</div>

@jywarren I see you did the initial install of pagy and I was wondering what you're thoughts on this are. It seems we may need an extra check in the <% if @pagy %> section. I think both the /questions and /questions/tag/{tag} route are defining their own @pagy and it's creating a little conflict with the two partials

[tyler-wel]

@jywarren Upon testing a little more and clicking on the "Asked" and "Answered" tabs on the questions/tag/ screen, it seems like those two tabs are not working correctly. Nothing changes upon clicking on them. In this case "Test" has been commented on, and "Test2" has not been commented on

[jywarren]

Fixed in #8689 ! Thank you!!!!