-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating questions to pagy #8445
Conversation
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
@publiclab/reviewers I think everything should be working, but questions wouldn't display in the last on either main or my branch. I made sure redis/sidekiq were running, and could make comments on the question after creating it. 🤔 |
Codecov Report
@@ Coverage Diff @@
## main #8445 +/- ##
=======================================
Coverage 81.87% 81.87%
=======================================
Files 101 101
Lines 5899 5899
=======================================
Hits 4830 4830
Misses 1069 1069
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @tyler-wel . Thanks for your contribution 🎉
@jywarren @cesswairimu for further review
Might be related to #7530, you can also tackle this one. 👍 |
Ah hmm, is it possible that they are not approved? If they are showing fine on stable.publiclab.org and publiclab.org, we should be ok. I'm going to merge this -- would you mind watching on http://stable.publiclab.org/questions once it finishes building to confirm that its' working there? Thank you so much!!!! |
Thank you so much! 👍 🎉 |
@jywarren But it seems fine on stable and prod! |
Fixes #8444
Added pagy for the questions route and paged.
Tried to test on the frontend, but was unable to actually create or populate the page with questions 🤔 ...
Well, I could create a question, but it was not displaying in the list even before I made any changes... 🤔
Atleast the pagy pages bar is showing correctly
rake test
@publiclab/reviewers
for help, in a comment belowCreated Question
Before (main)
After (this branch)
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!