Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating questions to pagy #8445

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Conversation

tyler-wel
Copy link
Contributor

@tyler-wel tyler-wel commented Oct 1, 2020

Fixes #8444

Added pagy for the questions route and paged.

Tried to test on the frontend, but was unable to actually create or populate the page with questions 🤔 ...

Well, I could create a question, but it was not displaying in the list even before I made any changes... 🤔

Atleast the pagy pages bar is showing correctly

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Created Question

image

Before (main)

image

After (this branch)

image

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Oct 1, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@gitpod-io
Copy link

gitpod-io bot commented Oct 1, 2020

@tyler-wel
Copy link
Contributor Author

tyler-wel commented Oct 1, 2020

@publiclab/reviewers I think everything should be working, but questions wouldn't display in the last on either main or my branch. I made sure redis/sidekiq were running, and could make comments on the question after creating it. 🤔

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #8445 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8445   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files         101      101           
  Lines        5899     5899           
=======================================
  Hits         4830     4830           
  Misses       1069     1069           
Impacted Files Coverage Δ
app/controllers/questions_controller.rb 90.78% <100.00%> (ø)

Copy link
Member

@avats-dev avats-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @tyler-wel . Thanks for your contribution 🎉

@jywarren @cesswairimu for further review

@avats-dev
Copy link
Member

@publiclab/reviewers I think everything should be working, but questions wouldn't display in the last on either main or my branch. I made sure redis/sidekiq were running, and could make comments on the question after creating it. thinking

Might be related to #7530, you can also tackle this one. 👍

@jywarren
Copy link
Member

jywarren commented Oct 2, 2020

Ah hmm, is it possible that they are not approved? If they are showing fine on stable.publiclab.org and publiclab.org, we should be ok. I'm going to merge this -- would you mind watching on http://stable.publiclab.org/questions once it finishes building to confirm that its' working there? Thank you so much!!!!

@jywarren jywarren merged commit 81bdcc8 into publiclab:main Oct 2, 2020
@jywarren
Copy link
Member

jywarren commented Oct 2, 2020

Thank you so much! 👍 🎉

@tyler-wel
Copy link
Contributor Author

@jywarren
Ahhh, you gotta approoooove the questions. I guess that's my fault for not fully knowing the platform as well 😅

But it seems fine on stable and prod!

image

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagy for questions route
3 participants