[WIP] Temporarily fixes double pagination on /questions/tag/

[tyler-wel]

Fixes #7530

Checks

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Description

Changes the _answered html fragment to check the existence of @answered_questions before rendering the pagy pagination.

Note, that this was not actually tested with answered questions because it seems that the Asked/Answered tabs are broken under the questions/tag screen. Clicking either tab does not change anything. @jywarren

Before

After

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

Merging #8479 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8479   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         101      101           
  Lines        5899     5894    -5     
=======================================
- Hits         4838     4834    -4     
+ Misses       1061     1060    -1     

Impacted Files	Coverage Δ
app/models/node.rb	91.45% <ø> (-0.07%)	⬇️
app/controllers/comment_controller.rb	86.95% <100.00%> (ø)
app/controllers/map_controller.rb	50.00% <100.00%> (ø)
app/controllers/questions_controller.rb	90.78% <100.00%> (ø)
app/controllers/search_controller.rb	97.67% <100.00%> (ø)
app/controllers/users_controller.rb	81.04% <100.00%> (-0.08%)	⬇️
app/models/spamaway.rb	97.43% <0.00%> (+2.56%)	⬆️

[jywarren]

Hi, this is looking good so far... did you need any help with it? Thanks!

[tyler-wel]

@jywarren There were some comments I made in the issue, and I realized the suggested fix doesn't 100% fix it... 😔

It's mainly because _questions and _tag => _answered are both rendering their @pagy blocks at the same time, and both controllers are using the @questions variable. The whole page it self doesn't seem to be working quite right, because when clicking on the asked and answered tabs at the top of the page doesn't change anything.

[jywarren]

@jywarren There were some comments I made in the issue, and I realized the suggested fix doesn't 100% fix it... 😔

It's mainly because _questions and _tag => _answered are both rendering their @pagy blocks at the same time, and both controllers are using the @questions variable. The whole page it self doesn't seem to be working quite right, because when clicking on the asked and answered tabs at the top of the page doesn't change anything.

Hi @tyler-wel - i'm so sorry it took me a while to circle back to this. Let me look at your code and maybe call in some help... i really appreciate your work here! Noting that this is still an issue at https://publiclab.org/questions/tag/water-quality and even the latest code at https://stable.publiclab.org/questions/tag/water-quality so this will be great to figure out. 🎉

[jywarren]

So, is the issue here that one of the pagination elements is for answered questions and the other is for unanswered? Looking at the two includes at

plots2/app/views/tag/show/_tab_content.html.erb

Lines 28 to 37 in 0633521

	<div class="tab-content">
	<div class="tab-pane active" id="asked-tab">
	<%= render partial: "questions/new_question" %>
	</div>
	<div class="tab-pane" id="answered-tab">
	<% if @answered_questions %>
	<%= render partial: "users/answered" %>
	<% end %>
	</div>

To test this theory, we could try commenting out one and seeing if the double pagination helper disappears.

Just to note, I believe we are OK eliminating the distinction between answered and unanswered in this display. Pinging @ebarry to confirm though.

[ebarry]

yes it does sound ok to eliminate the "answered | unanswered" toggle and the associated pagination.

One idea towards helping people choose which question card to potentially click on is to pull out the # of comments that is contained in the ... on each question card, and perhaps show these #s directly on the card to give people a sense of where there's a lot of dialogue/engagement.

[jywarren]

OK, great, so confirmed we can just remove the toggle, and hopefully that resolves the double pagination too!

I'm breaking out the design discussion portion into its own issue at: #8731

[jywarren]

Also we will move over to #8689 -- thanks!