Fix double pagination on tags questions

[Cadreia]

Fixes #8674 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

Merging #8689 (a4bb376) into main (903a162) will increase coverage by 0.07%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##             main    #8689      +/-   ##
==========================================
+ Coverage   81.85%   81.92%   +0.07%     
==========================================
  Files         100      100              
  Lines        5901     5930      +29     
==========================================
+ Hits         4830     4858      +28     
- Misses       1071     1072       +1     

Impacted Files	Coverage Δ
app/models/node.rb	91.47% <92.30%> (+0.01%)	⬆️
app/controllers/notes_controller.rb	84.46% <100.00%> (+0.93%)	⬆️
app/models/revision.rb	88.29% <100.00%> (+0.12%)	⬆️

[Cadreia]

@cesswairimu please is there any way I can narrow down on which functional tests are failing? It's been kind of challenging since the application builds locally without any errors

[Tlazypanda]

Hey @Cadreia You can find the tests failing by checking the travis logs 😅 Click on the details link next to the travis pull request check and then navigate to functional tests For example your run is accessible here https://travis-ci.com/github/publiclab/plots2/jobs/414753485 So from this log you can see that the should_have_a_active_asked_and_an_inactive_answered_tab_for_question and wildcard_tag_should_have_a_active_asked_and_an_inactive_answered_tab_for_question tests are failing

[Cadreia]

Thank you @Tlazypanda. I'll get back to you if I face any further difficulties

[cesswairimu]

Did you manage to see the errors? here is an image

[jywarren]

Oh no! It looks like this and #8479 (comment) are both setting out to fix the same issue. @tyler-wel @Cadreia would you be able to work together to resolve this, or perhaps as @Cadreia has more recently been working on it, @Cadreia would like to take this one on?

I'm sorry we didn't notice the overlap sooner - thank you for all your work, both of you!

[tyler-wel]

Oh no! It looks like this and #8479 (comment) are both setting out to fix the same issue. @tyler-wel @Cadreia would you be able to work together to resolve this, or perhaps as @Cadreia has more recently been working on it, @Cadreia would like to take this one on?

I'm sorry we didn't notice the overlap sooner - thank you for all your work, both of you!

I'm fine with Cadreia taking oevr!

[jywarren]

OK, thank you and I appreciate your understanding ❤️

@Cadreia just notifying you too!

[Cadreia]

Okay, I'll try completing this as soon as possible.

…

On Mon, Nov 9, 2020, 11:29 PM Jeffrey Warren ***@***.***> wrote: OK, thank you and I appreciate your understanding ❤️ @Cadreia <https://github.com/Cadreia> just notifying you too! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8689 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJVPFHAFXVAQYRPTQBXRWETSPBUNTANCNFSM4TCP2Z4A> .

[codeclimate]

Code Climate has analyzed commit a8eda74 and detected 0 issues on this pull request.

View more on Code Climate.

[Cadreia]

Hi, @jywarren. I succeeded in getting the tests to pass for this. Can you please review it?

[cesswairimu]

@Cadreia I am getting 502 on gitpod..not sure why...do you minding adding a screenshot for this?
thanks for working on this 🎉

[Cadreia]

Hi, @cesswairimu. I just opened this on gitpod, and I didn't come across a 502 error.
I added a screenshot in the PR description. Or would you prefer I include a gif instead?

[cesswairimu]

Hi @Cadreia , the screenshot is fine. Its late over here, I will take a look tomorrow. Thanks

[jywarren]

This looks perfect, thank you!!!!