Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http to https on note_controller test #9245

Closed
5 tasks
first-timers bot opened this issue Mar 2, 2021 · 2 comments · Fixed by #9261
Closed
5 tasks

http to https on note_controller test #9245

first-timers bot opened this issue Mar 2, 2021 · 2 comments · Fixed by #9261
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. summer-of-code

Comments

@first-timers
Copy link

first-timers bot commented Mar 2, 2021

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file test/functional/notes_controller_test.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -70,13 +70,13 @@ def teardown
     node = Node.where(type: 'note', status: 1).first
     assert node.comments.length > 0
     comment = node.comments.last(2).first
-    comment.comment = 'Test **markdown** and http://links.com'
+    comment.comment = 'Test **markdown** and https://links.com'
     comment.save!
 
     get :show, params: { id: node.id }
 
     assert_select 'strong', 'markdown'
-    assert_select 'a', 'http://links.com'
+    assert_select 'a', 'https://links.com'
 
     assert_response :success
   end
@@ -483,13 +483,13 @@ def teardown
     comment = Comment.new(nid: nodes(:one).nid,
                           uid: users(:bob).id,
                           thread: '01/')
-    comment.comment = '<iframe src="http://mapknitter.org/embed/sattelite-imagery" style="border:0;"></iframe>'
+    comment.comment = '<iframe src="https://mapknitter.org/embed/sattelite-imagery" style="border:0;"></iframe>'
     comment.save
     node = nodes(:one).path.split('/')
 
     get :show, params: { id: node[4], author: node[2], date: node[3] }
 
-    assert_select 'iframe[src=?]', 'http://mapknitter.org/embed/sattelite-imagery'
+    assert_select 'iframe[src=?]', 'https://mapknitter.org/embed/sattelite-imagery'
   end
 
   # test "should mark admins and moderators with a special icon" do
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Mar 2, 2021
@cesswairimu
Copy link
Collaborator

Reserved for @lagunasmel

@lagunasmel
Copy link
Contributor

@cesswairimu Working on it! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. summer-of-code
Projects
None yet
2 participants