Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil navigator on admin check room_channel #9766

Closed
5 tasks
first-timers bot opened this issue Jun 9, 2021 · 10 comments · Fixed by #9834
Closed
5 tasks

add nil navigator on admin check room_channel #9766

first-timers bot opened this issue Jun 9, 2021 · 10 comments · Fixed by #9834
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@first-timers
Copy link

first-timers bot commented Jun 9, 2021

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/channels/room_channel.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -9,7 +9,7 @@ def unsubscribed
   end
 
   def speak(message)
-    return unless current_user && current_user.admin?
+    return unless current_user&.admin?
 
     ActionCable.server.broadcast 'room_channel', message: message["message"]
   end
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are not familiar with GitHub or the pull request model, here is a guide you can follow on how GitHub works.

  2. If you are familiar with the terminal or would like to learn to use it, here is a great tutorial on how to send a pull request using the terminal.

  3. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Jun 9, 2021
@cesswairimu
Copy link
Collaborator

reserved for @jdcbautista

@AbhigyanSrivastav
Copy link
Contributor

Can i work on this.

@cesswairimu cesswairimu removed the help wanted requires help by anyone willing to contribute label Jun 12, 2021
@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 12, 2021

Hi @CYBER-BRIX this is reserved and I see you already worked on first-timer-issue #9764 ... kindly browse through issues labelledhelp-wanted to find something to work on next Thanks

@TildaDares
Copy link
Member

@cesswairimu Should this issue be assigned to someone else since @jdcbautista hasn't responded?

@AbhigyanSrivastav
Copy link
Contributor

@TildaDares , @cesswairimu i would really love to work on this issue..!

@TildaDares
Copy link
Member

@CYBER-BRIX Like @cesswairimu said you've already worked on a first-timer-issue. There are other issues without the first-timers-only tag you can work on. Thanks!

@sab30-webdev
Copy link
Contributor

@TildaDares ,@cesswairimu. Can I solve this issue ,I haven't contributed , this would be my first time contribution

@Diptime
Copy link
Contributor

Diptime commented Jun 20, 2021

I've been given this issue. :)

@Diptime
Copy link
Contributor

Diptime commented Jun 21, 2021

Opened a PR

@cesswairimu
Copy link
Collaborator

Hey @TildaDares I am sorry I missed this...yeah please feel free to reassign an fto if no updates / pr created for a week.

@sab30-webdev looks like @Diptime already created a PR...please browse through the issues and feel free to ping me if you don't find an issue.
Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants