Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove background from wiki links shown on profile sidebar #5166

Conversation

EngrEric
Copy link

@EngrEric EngrEric commented Mar 19, 2019

Fixes #4980
image

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Mar 19, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
Also, can you tell us your Twitter handle so we can thank you properly?

@EngrEric
Copy link
Author

@gauravano the PR is ready to be reviewed.
assign more task to me

@plotsbot
Copy link
Collaborator

1 Message
📖 @EngrEric Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@IshaGupta18
Copy link
Collaborator

@gauravano I think this is good to go!

@grvsachdeva
Copy link
Member

@EngrEric great work! Do you think we can further do some more improvements here like decreasing space between wiki title and updated about line and increasing space a little between 2 wiki entries?

Thanks!

@EngrEric
Copy link
Author

@EngrEric great work! Do you think we can further do some more improvements here like decreasing space between wiki title and updated about line and increasing space a little between 2 wiki entries?

Thanks!

i think it will cool too, i will give it a try

@SidharthBansal
Copy link
Member

Hi, how is it going?
Just checking if you are stuck somewhere?

@EngrEric
Copy link
Author

Hi, how is it going?
Just checking if you are stuck somewhere?

not stuck, just had some busy moments.
i will finish up my code ASAP

@SidharthBansal
Copy link
Member

No problem. Whenever you get some time please complete it.
Thanks

@grvsachdeva
Copy link
Member

Hi @EngrEric, I am closing this PR for now. But, you are very welcome to complete it whenever you get time. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove background from wiki links shown on profile sidebar
5 participants