Removed unused admin section #6901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide us a screenshot of before and after the changes are done! |
|
@SidharthBansal I'm not quite sure what to screenshot. This PR removes the unused admin section, as described in #6864, with no actual UI changes (seems to be more of a code refactoring issue). |
|
I thought that erb file's code snippet you removed should also remove some
front end code
Please check and let me know. Please take a review from the issue creator
so that I can merge.
Thank you
…On Thu, 5 Dec 2019, 4:05 am Robert Chen, ***@***.***> wrote:
@SidharthBansal <https://github.com/SidharthBansal> I'm not quite sure
what to screenshot. This PR removes the unused admin section, as described
in #6864 <#6864>, with no
actual UI changes (seems to be more of a code refactoring issue).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6901?email_source=notifications&email_token=AFAAEQ5QVYNJEO3GUCAU73LQXAWEHA5CNFSM4JU5XWV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF6XTDI#issuecomment-561871245>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQ5YULDSLRMFK2EP7LTQXAWEHANCNFSM4JU5XWVQ>
.
|
|
@SidharthBansal sorry, I double-checked and it removes the "Add a tag parent" from the dropdown menu. Before: After: This is only shown to admin users however, due to the |
|
Can you tell me about code links so that I can approve them?
…On Thu, 5 Dec 2019, 11:53 am Robert Chen, ***@***.***> wrote:
@SidharthBansal <https://github.com/SidharthBansal> sorry, I
double-checked and it removes the "Add a tag parent" from the dropdown menu.
Before:
[image: image]
<https://user-images.githubusercontent.com/20526314/70209247-96686500-16e4-11ea-8ae2-76bf4a63e11e.png>
After:
[image: image]
<https://user-images.githubusercontent.com/20526314/70209278-b1d37000-16e4-11ea-815d-43369d71e626.png>
This is only shown to admin users however, due to the <% if
logged_in_as(['admin']) %> check.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6901?email_source=notifications&email_token=AFAAEQ2LIRR7HM5HWARBEPTQXCM73A5CNFSM4JU5XWV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF7UOPI#issuecomment-561989437>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFAAEQY3BPOLWSWMSGOW2ITQXCM73ANCNFSM4JU5XWVQ>
.
|
SidharthBansal
approved these changes
Dec 5, 2019
|
Superb 🎉 |
|
Thanks! Which code links did you want me to provide? |
|
I meant that you can tell me the task url on GCI dashboard so that I can approve it there. |
Tlazypanda
pushed a commit
to Tlazypanda/plots2
that referenced
this pull request
Jan 14, 2020
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6864
I removed the unused admin section from
app/views/tag/show/_user_controls.html.erb.@jywarren @gauravano @ananyaarun could you take a look please? Thanks!