Login Modal redesign #455

IshaGupta18 · 2019-05-04T08:22:32Z

Fixes #448

Here is the design for the new login modal. I have deliberately kept the username field so that we can discuss if it's a good idea to remove it or not:

SidharthBansal · 2019-05-05T03:14:13Z

app/views/sessions/login.html.erb

-    <%= hidden_field_tag :back_to,@referer  -%>
-
-    <input tabindex="1" placeholder="username" id="username" name="open_id" type="text" /></p>
-    <input type="hidden" name="return_to" value="<%= params[:return_to] %>" />


May I know why we deleted line 10 and 13?
I think there is need of these lines in the controller

Can you please ensure no params key is deleted from the views?

params[:return_to] is changed to params[:back_to]

app/views/sessions/login.html.erb

app/views/sessions/_login.html.erb

SidharthBansal · 2019-05-09T06:34:34Z

Please provide the final screenshots

IshaGupta18 · 2019-05-09T06:36:18Z

SidharthBansal · 2019-05-09T06:38:52Z

Awesome

jywarren · 2019-05-09T17:10:16Z

Super!!!!

SidharthBansal · 2019-05-09T17:33:56Z

Hi @jywarren this PR needs to be merged with other 3 PRS.
Work is in parallel as I told you yesterday.
Thanks for merging.

jywarren · 2019-05-09T17:36:49Z

Uh oh, sorry, it wasn't marked "do not merge" and it wasn't in our checklist... OK, i'll note to Sebastian that this shouldn't be published until publiclab/plots2#5640 is merged. Thanks!

jywarren · 2019-05-09T17:37:18Z

Er, i meant publiclab/plots2#5652

jywarren · 2019-05-09T17:38:29Z

Ack, sorry! #448 was in the checklist. But it was already checked.

SidharthBansal · 2019-05-09T17:39:55Z

I am really sorry. I did not label it. Sorry.

…

On Thu, May 9, 2019, 11:07 PM Jeffrey Warren ***@***.***> wrote: Er, i meant publiclab/plots2#5652 <publiclab/plots2#5652> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#455 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQ7M6RJAT63GEFOJWV3PURONBANCNFSM4HKYMUZA> .

SidharthBansal · 2019-05-09T18:00:43Z

You did it correctly. We need to deploy things simultaneously to production.
I used merge in #455 (comment) but I should write deploy. Sorry I wrote wrong word.
Thanks for merging.

jywarren · 2019-05-09T18:15:33Z

no issue! I marked it and we should be fine. Thanks for your care and help here! On Thu, May 9, 2019 at 1:40 PM Sidharth Bansal <notifications@github.com> wrote:

…

I am really sorry. I did not label it. Sorry. On Thu, May 9, 2019, 11:07 PM Jeffrey Warren ***@***.***> wrote: > Er, i meant publiclab/plots2#5652 > <publiclab/plots2#5652> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #455 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AFAAEQ7M6RJAT63GEFOJWV3PURONBANCNFSM4HKYMUZA > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#455 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J3Y5LMWFEDMGCEIYUDPUROWXANCNFSM4HKYMUZA> .

Login Modal redesign

4b32bcf