Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(optim): input rules are now deep copied [NGC-110] #31

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

EmileRolley
Copy link
Collaborator

Fixes #30 and partially #29

@EmileRolley EmileRolley force-pushed the fix-input-rules-shouldn't-be-modified branch from 1205d8c to a03f758 Compare December 12, 2023 17:53
@EmileRolley EmileRolley changed the title Input parsed rules shouldn't be modified Input parsed rules shouldn't be modified - [NGC-110] Dec 12, 2023
@EmileRolley EmileRolley force-pushed the fix-input-rules-shouldn't-be-modified branch from 496afc5 to 3c5dfbe Compare December 12, 2023 17:55
@EmileRolley EmileRolley added 🐛 bug Something isn't working ⚡ optims Issues related to the `optims` module labels Dec 12, 2023
@EmileRolley EmileRolley changed the title Input parsed rules shouldn't be modified - [NGC-110] Fix(optim): input rules are now deep copied [NGC-110] Dec 12, 2023
@EmileRolley EmileRolley merged commit 5ee4207 into main Dec 12, 2023
6 checks passed
@EmileRolley EmileRolley deleted the fix-input-rules-shouldn't-be-modified branch December 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working ⚡ optims Issues related to the `optims` module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: input rules shouldn't been modified by constantFolding
1 participant