-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'master' to 'main' #1348
Comments
Will double check but I believe the autopull code should Just Work with an updated convergence branch name. I don't recall hardcoding "master" anywhere. |
This makes sense to do in order to align with the sensitivities
I have no bias - as long as there is an authoritative
'top'/'live'/'current' it can be called Chewbacca for all I care. :)
…On Mon, Jun 7, 2021 at 9:31 AM Daniel McCarney ***@***.***> wrote:
@cpu <https://github.com/cpu> (in case you know of any other automation
cases)
Will double check but I believe the autopull code should Just Work with an
updated convergence branch name. I don't recall hardcoding "master"
anywhere.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJPGCGM4AB72GDGADADTRTX75ANCNFSM46IA2G5A>
.
|
I added one item. We've done it in DNSimple for all our public/private repo, it was mostly trivial. The main challenge are hard-coded references. My primary concern would be confirm with Mozilla that nothing will break. |
👋 I think this may break how we currently build the project. Let me know when you want to make this change so we can coordinate and ensure the build is functioning correctly. |
any progress👀 |
If nobody objects I would like to do this this week or next week. @bkochendorfer how much of a heads up do you need to fix the deployment pipeline? |
@weppos Just rename it, the rest should be trivial. |
Done. These are the instructions for local git repos.
|
This broke the atom feed.
…On Wed, Nov 6, 2024, 5:07 AM Simone Carletti ***@***.***> wrote:
Done. These are the instructions for local git repos.
git branch -m master main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a
—
Reply to this email directly, view it on GitHub
<#1348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJKYKVK4QVWA7EIVLBLZ7IH7HAVCNFSM6AAAAABJHVNIG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZG4YDMNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@dnsguru Did you update the feed address? |
I didn't touch anything related to this master->main pr
…On Thu, Nov 7, 2024, 9:12 AM Simon Friedberger ***@***.***> wrote:
@dnsguru <https://github.com/dnsguru> Did you update the feed address?
—
Reply to this email directly, view it on GitHub
<#1348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJKHOC6YIIF7UJUP4WLZ7MOINAVCNFSM6AAAAABJHVNIG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRGU4DCNBWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Since the feed address contains the branch name you need to update the address of the feed. I've updated the entry in the wiki where we publish that address but you still have to change the address in your feedreader. |
I have a change ready to be shipped Any other change required? |
@simon-friedberger any other change required? |
@weppos Could you please do the same for the website repository? Might as well fix them both now. |
Sure thing. Done. |
Consistent with https://github.com/github/renaming , this should be fairly trivial.
Tasks to do:
We can add other tracking items to this, for other downstream replicators/bots. I'd tentatively suggest a date of 2021-07-14, just so that we're not tackling it around any holidays or weekends, and to give folks a chance to add dependencies to this list that should be considered.
The text was updated successfully, but these errors were encountered: