Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add IDN ccTLD .ישראל and SLDs for Israel by ISOC-IL #1595

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

guidlbb
Copy link
Contributor

@guidlbb guidlbb commented Aug 11, 2022

Description of Organization

Israel Internet Association (ISOC-IL) is Israel’s country code top-level domains (ccTLD) registry, responsible for managing .il domain names and ישראל. TLD and SLDs.

ISOC-IL is the Israeli chapter of the Internet Society (ISOC.ORG).

Organization Website:

https://isoc.org.il/

Reason for PSL Inclusion

Israel Internet Association (ISOC-IL) is Israel’s country code top-level domains (ccTLD) registry, responsible for managing .il domain names and ישראל. TLD and SLDs.

We would like to update the list with the new IDN - .ישראל / xn--4dbrk0ce TLD and SLDs

Root Zone Database Record

https://www.iana.org/domains/root/db/xn--4dbrk0ce.html

DNS Verification via dig

$ dig TXT _PSL.ישראל. +short
"https://github.com/publicsuffix/list/pull/1595"

make test

============================================================================
Testsuite summary for libpsl 0.21.1
============================================================================
# TOTAL: 3
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in tests
  CC       test-is-public.o
  CC       test-is-cookie-domain-acceptable.o
  CC       test-is-public-all.o
  CC       test-is-public-builtin.o
  CC       test-registrable-domain.o
  CCLD     test-is-cookie-domain-acceptable
  CCLD     test-is-public-builtin
  CCLD     test-is-public
  CCLD     test-is-public-all
  CCLD     test-registrable-domain
PASS: test-is-public-builtin
PASS: test-is-public
PASS: test-is-cookie-domain-acceptable
PASS: test-registrable-domain
PASS: test-is-public-all
============================================================================
Testsuite summary for libpsl 0.21.1
============================================================================
# TOTAL: 5
# PASS:  5
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
Making check in msvc

@guidlbb
Copy link
Contributor Author

guidlbb commented Aug 11, 2022

the validation record has been added :

dig TXT _PSL.ישראל.

; <<>> DiG 9.16.27-RH <<>> TXT _PSL.ישראל.
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 15552
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 8, ADDITIONAL: 12

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 65494
;; QUESTION SECTION:
;_psl.ישראל. IN TXT

;; ANSWER SECTION:
_psl.ישראל. 3600 IN TXT "#1595"

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is ICP-3 IDN ccTLD, listed in IANA DB
  • DNS Validation connects PR to Zone (see below)
  • Tests Pass
  • No Conflict With Base
  • Follows Guidelines (see note below)

APPROVED, with note

Note regarding guidelines... We typically locate the IDN ccTLD in an IDN section, but seek to move them gradually to be aligned with the associated ccTLD administrator where they are operated by the same entity (some are not) in the future. We will keep this as submitted in the interest of it being in the future format vs migrating it now and then having to again later.

DNS Validation Results:

[psl]$  dig TXT +short +noidnout _psl.xn--4dbgdty6c.xn--4dbrk0ce. @1.1.1.1
"https://github.com/publicsuffix/list/pull/1595"
[psl]$  dig TXT +short +noidnout _psl.xn--5dbhl8d.xn--4dbrk0ce. @1.1.1.1
"https://github.com/publicsuffix/list/pull/1595"
[psl]$  dig TXT +short +noidnout _psl.xn--4dbrk0ce. @1.1.1.1
"https://github.com/publicsuffix/list/pull/1595"
[psl]$  dig TXT +short +noidnout _psl.xn--8dbq2a.xn--4dbrk0ce. @1.1.1.1
"https://github.com/publicsuffix/list/pull/1595"
[psl]$  dig TXT +short +noidnout _psl.xn--hebda8b.xn--4dbrk0ce. @1.1.1.1
"https://github.com/publicsuffix/list/pull/1595"

@dnsguru dnsguru changed the title new TLD .ישראל and SLDs for Israel by ISOC-IL add IDN ccTLD .ישראל and SLDs for Israel by ISOC-IL Aug 11, 2022
@dnsguru dnsguru merged commit 05be67f into publicsuffix:master Aug 11, 2022
@dnsguru dnsguru self-assigned this Aug 11, 2022
@dnsguru dnsguru added the NOT IOS FB Submitter attests PR is not #1245 related label Aug 11, 2022
@dnsguru dnsguru added the r=dnsguru Marked as approved and ready to merge by @dnsguru label Aug 11, 2022
@dnsguru
Copy link
Member

dnsguru commented Aug 11, 2022

Thank you @guidlbb for submitting this. It has been merged, which was gratefully simple as it was clear that there was high competence and attention to this PR that allowed the volunteers to glide it right into the PSL.

We ultimately would like to get the IDN ccTLDs that are associated with the same IANA entity operating the ISO3166 string migrated from their current section into the same section where it is a combined operation,
like is done in this case. I appreciate the care, substance and precision with which this PR was submitted, and I will refer back to it as an example of how other ccTLDs that operate their respective IDN ccTLD should also do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related r=dnsguru Marked as approved and ready to merge by @dnsguru
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants