Do not await disconnect forever #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, do a short `delay()` in each iteration. This should allow the rest of the SW to "do its stuff", like, kicking the WDT and such.
There was a bug in PubSubClient::stop() - a surplus call to `input_state()`. Also, it now waits for data shorter, not the usual "full (default) time" . This time is not yet user settable. Since ESP8266 can, in some weird and as-of-yet-unexplained situations, take a _long_ time (hours, even) to change the state of the `WiFiClient` to "not connected" after a `stop()`, we no longer await this disconnection "forever". There is now a timeout (for now, not user-settable) and we give up after a short while. This might lead to some (probably temporary) leaks, but, we haven't run into problems in our testing.
vveljko
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.