Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make publish/grant workers per instance #101

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Conversation

crimsonred
Copy link
Contributor

No description provided.

@PubNubBot
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/e2e/subscribe_test_1.9.go  1
- tests/e2e/pn_test.go  1
- tests/e2e/objects_test.go  8
         

Clones added
============
- tests/e2e/grant_token_test.go  1
- tests/e2e/history_test.go  1
- tests/e2e/subscribe_test.go  5
- tests/e2e/subscribe_test_1.9.go  1
- tests/e2e/message_actions_test.go  3
- tests/e2e/objects_test.go  3
         

See the complete overview on Codacy

@jzucker2
Copy link

jzucker2 commented Feb 3, 2020

Codecov Report

Merging #101 into develop will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
- Coverage    80.83%   80.76%   -0.08%     
===========================================
  Files           62       62              
  Lines         6899     6899              
===========================================
- Hits          5577     5572       -5     
- Misses        1147     1152       +5     
  Partials       175      175              
Impacted Files Coverage Δ
listener_manager.go 82.03% <0.00%> (-2.35%) ⬇️
pubnub.go 74.03% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1347836...57eca7d. Read the comment docs.

Copy link
Contributor

@davidnub davidnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM! 👍

@crimsonred crimsonred merged commit 8fb1309 into develop Feb 4, 2020
@crimsonred crimsonred deleted the hotfix/CE-4333-Race2 branch February 6, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants