Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send empty optional parameters in objects #122

Merged
merged 5 commits into from
Feb 10, 2022
Merged

Do not send empty optional parameters in objects #122

merged 5 commits into from
Feb 10, 2022

Conversation

kleewho
Copy link
Contributor

@kleewho kleewho commented Feb 7, 2022

fix: Omit empty optional parameters for UUID or channel metadata

@codecov-commenter
Copy link

Codecov Report

Merging #122 (b70ce6f) into master (ceb3da6) will decrease coverage by 3.01%.
The diff coverage is 74.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   80.84%   77.82%   -3.02%     
==========================================
  Files          62       73      +11     
  Lines        6953     8484    +1531     
==========================================
+ Hits         5621     6603     +982     
- Misses       1156     1641     +485     
- Partials      176      240      +64     
Impacted Files Coverage Δ
remove_all_push_channels_request.go 67.85% <ø> (-0.90%) ⬇️
remove_channel_channel_group_request.go 86.66% <ø> (-2.07%) ⬇️
remove_channels_from_push_request.go 77.41% <ø> (-1.24%) ⬇️
request.go 80.62% <ø> (-0.92%) ⬇️
request_workers.go 80.85% <ø> (ø)
revoke_token.go 47.29% <ø> (ø)
set_state_request.go 86.44% <ø> (-1.28%) ⬇️
signal_request.go 72.64% <ø> (-0.81%) ⬇️
subscribe_request.go 74.44% <ø> (-1.14%) ⬇️
subscription_manager.go 74.92% <ø> (-0.82%) ⬇️
... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddde187...b70ce6f. Read the comment docs.

@kleewho
Copy link
Contributor Author

kleewho commented Feb 8, 2022

@client-engineering-bot release as v7.0.1

@kleewho kleewho removed the request for review from crimsonred February 10, 2022 11:11
Copy link

@phairow phairow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kleewho kleewho merged commit ecbfcda into master Feb 10, 2022
@kleewho kleewho deleted the CLEN-287 branch February 10, 2022 17:20
@github-actions
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants