Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded log file #16

Closed
FernandoEscher opened this issue Oct 23, 2013 · 4 comments
Closed

Hardcoded log file #16

FernandoEscher opened this issue Oct 23, 2013 · 4 comments

Comments

@FernandoEscher
Copy link

Is there a way to change the path for the log file?

It seems to me that you're creating a new Logger instance by hardcoding it to 'pubnub.log' and it is being save to the root of my project. This will imminently break my code for two reasons:

  1. I'm only tracking the logs falling under /path/to/project/log/*.log, so your log won't be tracked by the logging service I'm using. Also the log won't be rotated as all the other logs from my app.
  2. The permissions for the root folder are different from the log folder and I have some other processes expecting all logs to be readable under another sys user. This is breaking my app every time I deploy a new version and I have to go and change the permissions of the file manually.

All of this points me to the fact that there should be a config setting to select the path where I want the log to be and, optionally, to select the permissions for it.

Let me know if I just missed something in your code that could lead me to fix this issues, or if this capability can be built in the library.

@FernandoEscher
Copy link
Author

@geremyCohen
Copy link
Contributor

@FernandoEscher wow, you beat me to it. :) Is this resolved for you?

@FernandoEscher
Copy link
Author

It is. Thanks!

On Wed, Oct 23, 2013 at 7:49 PM, Geremy Cohen notifications@github.comwrote:

@FernandoEscher https://github.com/FernandoEscher wow, you beat me to
it. :) Is this resolved for you?


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-26956217
.

@geremyCohen
Copy link
Contributor

@FernandoEscher great! Feel free to ping us at support@pubnub.com for your free PubNub Tshirt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants