Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

positions modal in the viewable area in firefox #305

Closed
wants to merge 1 commit into from
Closed

positions modal in the viewable area in firefox #305

wants to merge 1 commit into from

Conversation

sdellis
Copy link
Member

@sdellis sdellis commented Jan 24, 2018 •
edited by escowles
Loading

Fixes #301

@coveralls
Copy link

coveralls commented Feb 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 97.731% when pulling 2d8d9c4 on issue-301 into a652e0c on master.

hackartisan
hackartisan requested changes Feb 22, 2018
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this on staging and it doesn't appear to fix the issue ☹️

@hackartisan
Copy link
Member

(fyi I rebased to get the updated deploy code so it could be deployed to staging)

@tpendragon tpendragon closed this Nov 26, 2018
@hackartisan hackartisan deleted the issue-301 branch September 24, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sdellis @coveralls @hackartisan @escowles @tpendragon