Import Metadata from Pulfa/Bibdata #6
Conversation
| attribute :title | ||
| attribute :label | ||
| attribute :visibility | ||
| def imported_schema |
There was a problem hiding this comment.
I like the idea of imported_schema, but it does make me think we should have a MarcRelatorsSchema etc. classes to clearly identify where some of these are coming from.
There was a problem hiding this comment.
Can we make an issue for that? I'm not sure the neatest way to bisect them. The only reason this exists is so that importing metadata won't wipe out all the non-imported metadata (IE source_metadata_identifier)
| private | ||
|
|
||
| def jsonld_request | ||
| @jsonld_request ||= Faraday.get("https://bibdata.princeton.edu/bibliographic/#{source_metadata_identifier}/jsonld") |
There was a problem hiding this comment.
TODO: we shouldn't be generating bibdata and pulfa URLs in our apps — I've added a ticket to pul_metadata_services for this: pulibrary/pul_metadata_services#18
| @@ -0,0 +1,34 @@ | |||
| # frozen_string_literal: true | |||
| module BibdataStubbing | |||
There was a problem hiding this comment.
👍 This is a lot simpler than VCR, and in particular, I'm looking forward to having human-readable sample records on disk instead of VCR's gnarly raw captures.
Gemfile
Outdated
| @@ -16,7 +16,7 @@ gem "simple_form" | |||
| gem "sprockets", ">= 3.0.0" | |||
| gem "title" | |||
| gem "uglifier" | |||
| gem "valkyrie", git: "https://github.com/samvera-labs/valkyrie.git" | |||
| gem "valkyrie", git: "https://github.com/samvera-labs/valkyrie.git", branch: "fix_date_parsing" | |||
There was a problem hiding this comment.
You can point this at master now that samvera/valkyrie#180 is merged
I'm doing my best to avoid VCR.