Add Save and Ingest functionality. #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpendragon
force-pushed
the
save_and_ingest
branch
from
17c900e
to
ce8c56f
Compare
hackartisan
requested changes
Dec 27, 2017
| @@ -84,7 +84,7 @@ export default class SaveWorkControl { | |||
| if (!this.form) { | |||
| return | |||
| } | |||
| this.saveButton = this.element.find(':submit') | |||
| this.saveButton = this.element.find(':submit').not("*[data-save-and-ingest]") | |||
There was a problem hiding this comment.
Is there another way to achieve this, maybe by adding a class to the desired save button? On the one hand I didn't know about this not and it's interesting. But on the other hand it feels like we shouldn't need to remember to come in here and make exceptions when adding new buttons.
There was a problem hiding this comment.
Good call. Fixed.
tpendragon
force-pushed
the
save_and_ingest
branch
from
ce8c56f
to
7900435
Compare
hackartisan
approved these changes
Dec 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #637.