Adds progress bar for loading images #885
Conversation
| var total = this.thumbnails.length | ||
| this.numLoaded = this.numLoaded + 1 | ||
| this.pctLoaded = this.numLoaded * 100 / total | ||
| console.log( 'image is ' + result + ' for ' + image.img.src ) |
There was a problem hiding this comment.
Do we want to leave the console logs?
|
I am going to remove the overlay, but keep the progress bar in the gallery (just make it thin and out of the way). I still think it's helpful to see when all the images have loaded, but it will not prevent one from working with the filemanager before all the images are loaded. Let's keep this PR open while I work on it. The new focus will be on a loading indicator for large manifests, not the images. The original issue was worded clearly, but since I've only been working with small manifests in dev, I mis-focused on the images which is what were taking a while to load for me. |
|
In order to test a large manifest, I tried seeding works with lots of images by upping the number of files in this line to 1000: It took a long time, but I only got 7 files with 1 image each. I'm going to need some guidance on how to do this come Monday. |
|
@tpendragon looking at this more closely and it seems that the manifest generation (over 10 seconds in my example case) is actually blocking the Rails layout/view rendering, so a loader/spinner does not appear while the user is waiting for the view to render. If we can render the manifest asynchronously, or after the view renders, we may be able to address this with a loader. |
|
@sdellis I'm confused. The file manager requests the manifest right? The only reason I can see that it would stop the rendering is if the file manager either isn't using ajax or the web server has one thread. |
fixes #762