Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes search form submit button in smaller screens #2346 #2174 #3860

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

christinach
Copy link
Member

@christinach christinach commented Dec 1, 2023

closes #2174
closes #2346

update and remove non existed classes in css.

@coveralls
Copy link

coveralls commented Dec 1, 2023

Coverage Status

coverage: 95.408%. remained the same
when pulling 8eb772f on 2174-submit-btnsearch-bar
into 56ca22d on main.

@christinach christinach changed the title Fixes search foirm submit button in smaller screens #2346 #2174 Fixes search form submit button in smaller screens #2346 #2174 Dec 1, 2023
@christinach
Copy link
Member Author

Deployed on catalog-staging

@christinach
Copy link
Member Author

Also it improves the alignment in between the search-widgets. See the screenshot. On the left side is staging with this branch deployed. On the right side is production.

Screenshot 2023-11-30 at 8 15 03 PM

@christinach christinach marked this pull request as ready for review December 1, 2023 01:17
@christinach christinach force-pushed the 2174-submit-btnsearch-bar branch 2 times, most recently from 0563c9f to 3bc89b5 Compare December 1, 2023 13:18
Also updates breaks with variables from Bottstrap4.
Updates css with existing classes. Removes old ones that are not used any more.
Copy link
Member

@kevinreiss kevinreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinreiss kevinreiss merged commit b615c0e into main Dec 1, 2023
10 checks passed
@kevinreiss kevinreiss deleted the 2174-submit-btnsearch-bar branch December 1, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants