Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3684: fix browse sorting for ayn character #3894

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

sandbergja
Copy link
Member

@sandbergja sandbergja commented Dec 7, 2023

closes #3864

I've run the author browse list in staging with this PR.

@sandbergja sandbergja force-pushed the i3864-ayn-sorting branch 3 times, most recently from 915df0e to 0262078 Compare December 7, 2023 21:24
@coveralls
Copy link

Coverage Status

coverage: 95.402%. remained the same
when pulling e99115d on i3864-ayn-sorting
into 3b64a77 on main.

@@ -17,7 +17,7 @@ def connection
dbuser = config['username']
dbname = config['database']
password = config['password']
port = config['port']
port = config['port'] || 5432
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was needed to get the rake task to run in circleci.

@sandbergja sandbergja marked this pull request as ready for review December 7, 2023 23:52
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sandbergja !

@kelea99
Copy link
Contributor

kelea99 commented Dec 8, 2023

Confirmed from Joyce Bell!! The ayn seems to be ok now. She hasnt run into any other characters with the same problem. you are good to go, @sandbergja and @christinach !

@christinach christinach merged commit 2c2a9a2 into main Dec 8, 2023
10 checks passed
@christinach christinach deleted the i3864-ayn-sorting branch December 8, 2023 15:13
@sandbergja
Copy link
Member Author

I will start running the browse lists in prod at 5pm eastern today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browse for the "ayn" character is off
4 participants