This repository has been archived by the owner on May 14, 2022. It is now read-only.
Use Hyrax description property and add abstract property #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tampakis
reviewed
Mar 24, 2017
| @@ -280,7 +280,7 @@ def build_file_set(id) | |||
| expect(result['@id']).to eq "http://plum.com/concern/scanned_resources/1/manifest" | |||
| end | |||
| it "has a description" do | |||
| expect(result.description).to eq [record.description] | |||
| expect(result.description).to eq [record.description.first] | |||
There was a problem hiding this comment.
This should be expect(result.description).to eq record.description right?
There was a problem hiding this comment.
They aren't equivalent. result.description is and Array. record.description is an RDF something something class. The test fails unless you cast that into an Array.
There was a problem hiding this comment.
Updated to use Array() instead.
tampakis
reviewed
Mar 24, 2017
| @@ -67,7 +67,7 @@ def metadata_hash | |||
| hsh[entry["label"].to_sym] = Array(entry["value"]).join(", ") | |||
| end | |||
| result[:Title] = Array(scanned_resource.title).join(", ") if scanned_resource.title | |||
| result[:Description] = Array(scanned_resource.description).join(", ") if scanned_resource.description | |||
| result[:Description] = scanned_resource.description.join(", ") if scanned_resource.description | |||
There was a problem hiding this comment.
I'm not sure this change is necessary. Array([1,2,3]) leaves the array unchanged, while ensuring the description field returns an array.
There was a problem hiding this comment.
Fair point. I'll revert the change.
eliotjordan
force-pushed
the
1132-description
branch
from
8b2e850
to
4eed3ba
Compare
|
I'm 👍, but I'll leave it to @tampakis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
descriptionproperty is now used instead of locally defined property.abstractproperty.Closes #1132