This repository has been archived by the owner on May 14, 2022. It is now read-only.
Initial pass of Box/Folder models + behavior #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a lot to do here still, but it's a good starting point so we can divide and conquer.
escowles
reviewed
Apr 21, 2017
| ActiveFedora::Indexers::GlobalIndexer.new([:symbol, :stored_searchable, :facetable]) | ||
| ) | ||
| # Change this to restrict which works can be added as a child. | ||
| # self.valid_child_concerns = [] |
There was a problem hiding this comment.
Do we want to limit to FileSet?
There was a problem hiding this comment.
Nah. This was meant to populate the "Add Child Work" drop down.
escowles
reviewed
Apr 21, 2017
| @@ -1,6 +1,7 @@ | |||
| module Workflow | |||
| class UpdatedEvent | |||
| def self.call(target:, **) | |||
| return unless target.is_a?(ScannedResource) || target.is_a?(MultiVolumeWork) | |||
There was a problem hiding this comment.
Do we want to maintain the list of models here, or add something to the models that should generate events?
|
I just pushed a commit that should get us to 💯 — and then I think this is ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot to do here still, but it's a good starting point so we can
divide and conquer.