Remove Multiple: False #1223
Remove Multiple: False #1223
Conversation
| @@ -11,8 +13,6 @@ def notable_rights_statement? | |||
| def self.multiple?(field) | |||
There was a problem hiding this comment.
Do we need to keep overriding multiple? here?
There was a problem hiding this comment.
I think it's only necessary for identifier, which needs weird behavior because of expectations in Grocer (we should fix that, but I didn't wanna cross gem boundaries for this)
There was a problem hiding this comment.
OK, that's fine — I've created an issue in Grocer for this: pulibrary/grocer#24
app/forms/hyrax/hyrax_form.rb
Outdated
| @@ -46,7 +46,7 @@ def rights_statement | |||
| if Array(self["rights_statement"]).first.blank? | |||
| "http://rightsstatements.org/vocab/NKC/1.0/" | |||
| else | |||
| self["rights_statement"] | |||
| Array(self["rights_statement"]).first | |||
There was a problem hiding this comment.
I think this could be simplified to something like:
self['rights_statement'] || 'http://rightsstatements.org/vocab/NKC/1.0/'
There was a problem hiding this comment.
It looks like self['rights_statement'] is getting initialized to an empty string, but I can make the conditional do a bunch less casting I think.
|
Looks good — there's just a couple of minor things that could be nice to clean up. |
tpendragon
force-pushed
the
remove_multiple_false
branch
from
6c11f3d
to
877b30f
Compare
It's gotten hard to handle which fields are allowed to be multi-valued and which aren't. In order to deal with conflicts and make the reasoning much easier to handle, make everything multi-valued and handle single-valued display via the forms (SingleValuedForm).
tpendragon
force-pushed
the
remove_multiple_false
branch
from
877b30f
to
6f61209
Compare
It's gotten hard to handle which fields are allowed to be multi-valued
and which aren't. In order to deal with conflicts and make the reasoning
much easier to handle, make everything multi-valued and handle
single-valued display via the forms (SingleValuedForm).